From: Paolo Bonzini <pbonzini@redhat.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
Liu Ping Fan <qemulist@gmail.com>,
Anthony Liguori <anthony@codemonkey.ws>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3 3/3] hpet: entitle more irq pins for hpet
Date: Fri, 30 Aug 2013 14:43:45 +0200 [thread overview]
Message-ID: <52209381.2070101@redhat.com> (raw)
In-Reply-To: <52209095.5030702@suse.de>
Il 30/08/2013 14:31, Andreas Färber ha scritto:
>> > static Property hpet_device_properties[] = {
>> > DEFINE_PROP_UINT8("timers", HPETState, num_timers, HPET_MIN_TIMERS),
>> > DEFINE_PROP_BIT("msi", HPETState, flags, HPET_MSI_SUPPORT, false),
>> > + DEFINE_PROP_UINT32("intcap", HPETState, intcap, HPET_TN_INT_CAP_DEFAULT),
> What is "intcap"? It sounds like capabilities? In that case
> DEFINE_PROP_BIT() might be a more appropriate way to model individually
> tweakable properties? Either way, the property name could probably use
> some love for clarity - there is no explanation for users.
Unless you want 24 properties (one per pin), an UINT32 is fine. :)
Paolo
prev parent reply other threads:[~2013-08-30 12:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-30 7:53 [Qemu-devel] [PATCH v3 0/3] bugs fix for hpet Liu Ping Fan
2013-08-30 7:53 ` [Qemu-devel] [PATCH v3 1/3] hpet: inverse polarity when pin above ISA_NUM_IRQS Liu Ping Fan
2013-08-30 7:53 ` [Qemu-devel] [PATCH v3 2/3] qdev: interface for SysBusDevice to change property on requirement Liu Ping Fan
2013-08-30 8:17 ` Paolo Bonzini
2013-08-30 12:32 ` Andreas Färber
2013-09-02 6:11 ` liu ping fan
2013-09-02 6:10 ` liu ping fan
2013-08-30 8:31 ` Peter Maydell
2013-08-30 7:53 ` [Qemu-devel] [PATCH v3 3/3] hpet: entitle more irq pins for hpet Liu Ping Fan
2013-08-30 12:31 ` Andreas Färber
2013-08-30 12:43 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52209381.2070101@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=anthony@codemonkey.ws \
--cc=jan.kiszka@siemens.com \
--cc=qemu-devel@nongnu.org \
--cc=qemulist@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).