From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46196)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VFO3X-0000Og-V3
	for qemu-devel@nongnu.org; Fri, 30 Aug 2013 08:44:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VFO3P-0005GM-IZ
	for qemu-devel@nongnu.org; Fri, 30 Aug 2013 08:44:03 -0400
Received: from mail-ee0-x230.google.com ([2a00:1450:4013:c00::230]:41304)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VFO3P-0005Fx-8M
	for qemu-devel@nongnu.org; Fri, 30 Aug 2013 08:43:55 -0400
Received: by mail-ee0-f48.google.com with SMTP id l10so888360eei.35
	for <qemu-devel@nongnu.org>; Fri, 30 Aug 2013 05:43:54 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <52209381.2070101@redhat.com>
Date: Fri, 30 Aug 2013 14:43:45 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1377849232-27822-1-git-send-email-pingfank@linux.vnet.ibm.com>
	<1377849232-27822-4-git-send-email-pingfank@linux.vnet.ibm.com>
	<52209095.5030702@suse.de>
In-Reply-To: <52209095.5030702@suse.de>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH v3 3/3] hpet: entitle more irq pins for hpet
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
Cc: Jan Kiszka <jan.kiszka@siemens.com>, Liu Ping Fan <qemulist@gmail.com>, Anthony Liguori <anthony@codemonkey.ws>, qemu-devel@nongnu.org

Il 30/08/2013 14:31, Andreas Färber ha scritto:
>> >  static Property hpet_device_properties[] = {
>> >      DEFINE_PROP_UINT8("timers", HPETState, num_timers, HPET_MIN_TIMERS),
>> >      DEFINE_PROP_BIT("msi", HPETState, flags, HPET_MSI_SUPPORT, false),
>> > +    DEFINE_PROP_UINT32("intcap", HPETState, intcap, HPET_TN_INT_CAP_DEFAULT),
> What is "intcap"? It sounds like capabilities? In that case
> DEFINE_PROP_BIT() might be a more appropriate way to model individually
> tweakable properties? Either way, the property name could probably use
> some love for clarity - there is no explanation for users.

Unless you want 24 properties (one per pin), an UINT32 is fine. :)

Paolo