From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50356)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1VFOKp-0002HK-La
	for qemu-devel@nongnu.org; Fri, 30 Aug 2013 09:02:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1VFOKi-0001u6-6Z
	for qemu-devel@nongnu.org; Fri, 30 Aug 2013 09:01:55 -0400
Message-ID: <522097B5.7060604@suse.de>
Date: Fri, 30 Aug 2013 15:01:41 +0200
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1375863692-12207-1-git-send-email-aik@ozlabs.ru>
	<1375863692-12207-8-git-send-email-aik@ozlabs.ru>
	<8B8DDF27-87D9-4F0C-917C-85C22D417596@suse.de>
	<52204D28.3010702@ozlabs.ru>
In-Reply-To: <52204D28.3010702@ozlabs.ru>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 7/8] spapr vfio: add
 spapr-pci-vfio-host-bridge to support vfio
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: Anthony Liguori <aliguori@us.ibm.com>, "Michael S . Tsirkin" <mst@redhat.com>, Alexander Graf <agraf@suse.de>, qemu-devel <qemu-devel@nongnu.org>, Alex Williamson <alex.williamson@redhat.com>, qemu-ppc <qemu-ppc@nongnu.org>, Paolo Bonzini <pbonzini@redhat.com>, Paul Mackerras <paulus@samba.org>, David Gibson <david@gibson.dropbear.id.au>

Am 30.08.2013 09:43, schrieb Alexey Kardashevskiy:
> On 08/27/2013 09:08 PM, Alexander Graf wrote:
>>> type_init(register_types);
>>> diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c
>>> index 869ca43..3f37cac 100644
>>> --- a/hw/ppc/spapr_pci.c
>>> +++ b/hw/ppc/spapr_pci.c
>>
>> I think we should move the vfio phb into a separate file and make it b=
e a proper subclass without even the chance to randomly call normal spapr=
 pci functions ;).
>>
>> Andreas, could you please check through this and see if you can spot a=
 way to isolate it out?

Just noticing this question now... (me not so into reviewing VFIO)

> After the lesson you both gave me with xics/xics-kvm, I am (more or les=
s)
> aware of what I need to change here so wait a bit till I post another v=
ersion.

Thanks.

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg