From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54546) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VFOVH-0002Qc-8E for qemu-devel@nongnu.org; Fri, 30 Aug 2013 09:12:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VFOVC-0006dF-Co for qemu-devel@nongnu.org; Fri, 30 Aug 2013 09:12:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:21891) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VFOVC-0006d6-4C for qemu-devel@nongnu.org; Fri, 30 Aug 2013 09:12:38 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r7UDCb2J000448 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 30 Aug 2013 09:12:37 -0400 Message-ID: <52209A44.2010804@redhat.com> Date: Fri, 30 Aug 2013 07:12:36 -0600 From: Eric Blake MIME-Version: 1.0 References: <1377851804-13614-1-git-send-email-mreitz@redhat.com> <1377851804-13614-3-git-send-email-mreitz@redhat.com> <52209922.9080804@redhat.com> <52209958.90102@redhat.com> In-Reply-To: <52209958.90102@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="lA2ODOH2ofQRvPGgXsv91ctsKmcbS5N2w" Subject: Re: [Qemu-devel] [PATCH v2 2/2] qemu-iotests: Snapshotting zero clusters List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , qemu-devel@nongnu.org, Stefan Hajnoczi , Max Reitz This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --lA2ODOH2ofQRvPGgXsv91ctsKmcbS5N2w Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/30/2013 07:08 AM, Eric Blake wrote: > On 08/30/2013 07:07 AM, Eric Blake wrote: >> On 08/30/2013 02:36 AM, Max Reitz wrote: >>> This test creates an image with unallocated zero clusters, then creat= es >>> a snapshot. Afterwards, there should be neither any errors nor leaks.= >>> >>> Signed-off-by: Max Reitz >>> --- >>> tests/qemu-iotests/062 | 64 ++++++++++++++++++++++++++++++++++++++= ++++++++++ >>> tests/qemu-iotests/group | 1 + >>> 2 files changed, 65 insertions(+) >>> create mode 100755 tests/qemu-iotests/062 >> >> ACK. >=20 > Sorry, I'm mixing list conventions. That should be: >=20 > Reviewed-by: Eric Blake and just now, I notice the v3 patch that provides the expected output. Serves me right for trying to review first thing in the morning before breakfast. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --lA2ODOH2ofQRvPGgXsv91ctsKmcbS5N2w Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSIJpEAAoJEKeha0olJ0NqVbQH/3S83c4PIaIhlA61pwooK1Hz tbEyoDND72EDwBygB1qkYrk+GrqpA6oh+7GRCA61GFbUichCaKdRfSbpWCmW6Ci5 OqJjnmhsbRiIJFIo9iccKmQA4WeuEg4zMBGoRHmIVuQ7Qm+tAtVABPdomCP9voj6 ziWMS3zurCDx01Q184OFhhMDsToteaVtBxsxfGn+20gal8OiyAZRmCg/YqoekN8m uOAhHeswadV3Bm9vZGiuy0vnF0mbGQ/sMBSZti4CCepaVy8szY97oVOdJrsgL+/Y US5hLRfXvx+TPvNLFZYxZNWVET4JcKvOl4Xb1MLf5ayw9F4x73ZQUkRtgv3TEdo= =FwLq -----END PGP SIGNATURE----- --lA2ODOH2ofQRvPGgXsv91ctsKmcbS5N2w--