From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58725)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1VFOiO-0003Pz-78
	for qemu-devel@nongnu.org; Fri, 30 Aug 2013 09:26:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1VFOiG-0003d0-TW
	for qemu-devel@nongnu.org; Fri, 30 Aug 2013 09:26:16 -0400
Message-ID: <52209D6D.4020307@suse.de>
Date: Fri, 30 Aug 2013 15:26:05 +0200
From: =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1376606111-3518-1-git-send-email-afaerber@suse.de>
	<1376606111-3518-3-git-send-email-afaerber@suse.de>
	<A7792462-7662-49A0-80EF-A1C05C61BC5B@suse.de>
In-Reply-To: <A7792462-7662-49A0-80EF-A1C05C61BC5B@suse.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v2 2/4] spapr: Use DeviceClass::fw_name for
 device tree CPU node
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: qemu-ppc <qemu-ppc@nongnu.org>, qemu-devel@nongnu.org, Prerna Saxena <prerna@linux.vnet.ibm.com>

Am 30.08.2013 15:21, schrieb Alexander Graf:
>=20
> On 16.08.2013, at 00:35, Andreas F=E4rber wrote:
>=20
>> Instead of relying on cpu_model, obtain the device tree node label
>> per CPU. Use DeviceClass::fw_name when available. This implicitly
>> resolves HOST@0 node labels for those CPUs through inheritance.
>>
>> Whenever DeviceClass::fw_name is not available, derive it from the CPU=
's
>> type name and fill it in for that class with a "PowerPC," prefix for
>> PAPR compliance.
>=20
> Could we just mandate the fw_name field to always be set for all classe=
s instead?

Sure, we can assert it. But we would then need to set fw_name for the
various 970 families at least, which I have been using with pseries in
the past. Cell and POWER6 are TODO so I'm not concerned about them. Not
sure about RS64 that Alexey mentioned - I wouldn't be able to test.
Would be bad to regress and abort with CPU models that were working okay
before.

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg