qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: "Benoît Canet" <benoit@irqsave.net>
Cc: kwolf@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org,
	stefanha@redhat.com, pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH V7 4/5] block: Add support for throttling burst max in QMP and the command line.
Date: Fri, 30 Aug 2013 08:28:45 -0600	[thread overview]
Message-ID: <5220AC1D.8080103@redhat.com> (raw)
In-Reply-To: <1377702441-22236-5-git-send-email-benoit@irqsave.net>

[-- Attachment #1: Type: text/plain, Size: 768 bytes --]

On 08/28/2013 09:07 AM, Benoît Canet wrote:
> The max parameter of the leaky bucket throttling algorithm can be used to
> allow the guest to do bursts.
> The max value is a pool of I/O that the guest can use without being throttled
> at all. Throttling is triggered once this pool is empty.
> 
> Signed-off-by: Benoit Canet <benoit@irqsave.net>
> ---

> +++ b/qapi-schema.json
> @@ -785,6 +785,18 @@
>  #
>  # @image: the info of image used (since: 1.6)
>  #
> +# @bps_max: #optional total max in bytes (Since 1.7)

We don't have a consistent style, but at least the information is accurate.

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]

  reply	other threads:[~2013-08-30 14:29 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-28 15:07 [Qemu-devel] [PATCH V7 0/5] Continuous Leaky Bucket Throttling Benoît Canet
2013-08-28 15:07 ` [Qemu-devel] [PATCH V7 1/5] throttle: Add a new throttling API implementing continuous leaky bucket Benoît Canet
2013-08-28 15:07 ` [Qemu-devel] [PATCH V7 2/5] throttle: Add units tests Benoît Canet
2013-08-28 15:07 ` [Qemu-devel] [PATCH V7 3/5] block: Enable the new throttling code in the block layer Benoît Canet
2013-08-28 15:07 ` [Qemu-devel] [PATCH V7 4/5] block: Add support for throttling burst max in QMP and the command line Benoît Canet
2013-08-30 14:28   ` Eric Blake [this message]
2013-08-28 15:07 ` [Qemu-devel] [PATCH V7 5/5] block: Add iops_size to do the iops accounting for a given io size Benoît Canet
2013-08-30 14:39   ` Eric Blake
2013-08-29  9:09 ` [Qemu-devel] [PATCH V7 0/5] Continuous Leaky Bucket Throttling Stefan Hajnoczi
2013-08-29  9:37   ` Benoît Canet
2013-08-30  9:53     ` Stefan Hajnoczi
2013-08-30 10:06       ` Paolo Bonzini
2013-08-30 14:21         ` Stefan Hajnoczi
2013-08-29 18:01   ` Benoît Canet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5220AC1D.8080103@redhat.com \
    --to=eblake@redhat.com \
    --cc=benoit@irqsave.net \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).