From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51115) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VFPrf-00042S-C5 for qemu-devel@nongnu.org; Fri, 30 Aug 2013 10:39:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VFPra-0005xp-Rw for qemu-devel@nongnu.org; Fri, 30 Aug 2013 10:39:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:18814) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VFPra-0005xd-Jw for qemu-devel@nongnu.org; Fri, 30 Aug 2013 10:39:50 -0400 Message-ID: <5220AEB1.2090709@redhat.com> Date: Fri, 30 Aug 2013 08:39:45 -0600 From: Eric Blake MIME-Version: 1.0 References: <1377702441-22236-1-git-send-email-benoit@irqsave.net> <1377702441-22236-6-git-send-email-benoit@irqsave.net> In-Reply-To: <1377702441-22236-6-git-send-email-benoit@irqsave.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Ua7ag05WdSBHt5dgOxpO7RetOuPUUXa0x" Subject: Re: [Qemu-devel] [PATCH V7 5/5] block: Add iops_size to do the iops accounting for a given io size. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QmVub8OudCBDYW5ldA==?= Cc: kwolf@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, stefanha@redhat.com, pbonzini@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Ua7ag05WdSBHt5dgOxpO7RetOuPUUXa0x Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/28/2013 09:07 AM, Beno=C3=AEt Canet wrote: > This feature can be used in case where users are avoiding the iops limi= t by > doing jumbo I/Os hammering the storage backend. >=20 > Signed-off-by: Benoit Canet > --- > block/qapi.c | 3 +++ > blockdev.c | 21 ++++++++++++++++++--- > hmp.c | 8 ++++++-- > qapi-schema.json | 10 ++++++++-- > qemu-options.hx | 2 +- > qmp-commands.hx | 8 ++++++-- > 6 files changed, 42 insertions(+), 10 deletions(-) >=20 > @@ -1429,7 +1430,8 @@ Example: > "bps_wr_max": "0", > "iops_max": "0", > "iops_rd_max": "0", > - "iops_wr_max": "0" } } > + "iops_wr_max": "0", > + "iops_size": "0" } } Oh phooey, I failed to notice this on 4/5 - "0" is not a JSON int. This should be "bps_wr_max":0, ..., "iops_size": 0 } } > <- { "return": {} } > =20 > EQMP > @@ -1776,6 +1778,7 @@ Each json-object contain the following: > - "iops_max": total I/O operations max (json-int) > - "iops_rd_max": read I/O operations max (json-int) > - "iops_wr_max": write I/O operations max (json-int) > + - "iops_size": I/O size when limiting by iops (json-int) > - "image": the detail of the image, it is a json-object conta= ining > the following: > - "filename": image file name (json-string) > @@ -1851,6 +1854,7 @@ Example: > "iops_max": "0", > "iops_rd_max": "0", > "iops_wr_max": "0", > + "iops_size": "0", Here, too. All of the integers should be represented literally, not inside quotes. But since the problem is pre-existing before your series, and you are just the victim of copy-and-paste, I'm okay saving the cleanup to a separate patch, in which case: Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Ua7ag05WdSBHt5dgOxpO7RetOuPUUXa0x Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSIK6xAAoJEKeha0olJ0Nq9IgH/i836XhsMiCfc4NyM/UMph+/ OMgCgqHl1aS7QUw65Kus8ZRtum/+tTPLmFH7dxSHw7mK3XJq7zDuWB64lGJc2r2/ DaziwDv4nNBCcZKqUYCOoWS09sNO5du6LhHEaxFlQ/a//K9bYdYzMkZr16Efx3HI FUbXYeLmXvff12ans3Zpb2CQnG94N84lYnOQK8bK7Y8Ofu/R9KhcbXiY7uvQoX2A s095N88TXAv54/5pe5e3qi2xqsDL6wzeScIU0SBy385jhfo0Tx1cUtaZVv0Vd7d7 zlrtMaD3b0pwdxQb2iA8hPgozmjZKPy3VQY5DqkQKTTRAaYV2aXDJfGjKeFpjVc= =92++ -----END PGP SIGNATURE----- --Ua7ag05WdSBHt5dgOxpO7RetOuPUUXa0x--