From: Paolo Bonzini <pbonzini@redhat.com>
To: "Hervé Poussineau" <hpoussin@reactos.org>
Cc: qemu-trivial@nongnu.org, aliguori@us.ibm.com, av1474@comtv.ru,
qemu-devel@nongnu.org, qemu-stable@nongnu.org
Subject: [Qemu-devel] PING Re: [PATCH for-1.6] adlib: sort offsets in portio registration
Date: Fri, 30 Aug 2013 17:45:03 +0200 [thread overview]
Message-ID: <5220BDFF.2010906@redhat.com> (raw)
In-Reply-To: <1376473744-18435-1-git-send-email-hpoussin@reactos.org>
Il 14/08/2013 11:49, Hervé Poussineau ha scritto:
> This fixes the following assert when -device adlib is used:
> ioport.c:240: portio_list_add: Assertion `pio->offset >= off_last' failed.
>
> Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
> ---
> hw/audio/adlib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/audio/adlib.c b/hw/audio/adlib.c
> index 0421d47..db4a953 100644
> --- a/hw/audio/adlib.c
> +++ b/hw/audio/adlib.c
> @@ -284,9 +284,9 @@ static void Adlib_fini (AdlibState *s)
> }
>
> static MemoryRegionPortio adlib_portio_list[] = {
> - { 0x388, 4, 1, .read = adlib_read, .write = adlib_write, },
> { 0, 4, 1, .read = adlib_read, .write = adlib_write, },
> { 0, 2, 1, .read = adlib_read, .write = adlib_write, },
> + { 0x388, 4, 1, .read = adlib_read, .write = adlib_write, },
> PORTIO_END_OF_LIST(),
> };
>
>
Ping, and Cc to qemu-stable
next prev parent reply other threads:[~2013-08-30 15:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-14 9:49 [Qemu-devel] [PATCH for-1.6] adlib: sort offsets in portio registration Hervé Poussineau
2013-08-18 20:05 ` Hervé Poussineau
2013-08-30 15:45 ` Paolo Bonzini [this message]
2013-09-01 16:01 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5220BDFF.2010906@redhat.com \
--to=pbonzini@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=av1474@comtv.ru \
--cc=hpoussin@reactos.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).