From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41911) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VFQt0-00074I-AY for qemu-devel@nongnu.org; Fri, 30 Aug 2013 11:45:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VFQsr-0006Y9-Cu for qemu-devel@nongnu.org; Fri, 30 Aug 2013 11:45:22 -0400 Sender: Paolo Bonzini Message-ID: <5220BDFF.2010906@redhat.com> Date: Fri, 30 Aug 2013 17:45:03 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1376473744-18435-1-git-send-email-hpoussin@reactos.org> In-Reply-To: <1376473744-18435-1-git-send-email-hpoussin@reactos.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [Qemu-devel] PING Re: [PATCH for-1.6] adlib: sort offsets in portio registration List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?SGVydsOpIFBvdXNzaW5lYXU=?= Cc: qemu-trivial@nongnu.org, aliguori@us.ibm.com, av1474@comtv.ru, qemu-devel@nongnu.org, qemu-stable@nongnu.org Il 14/08/2013 11:49, Hervé Poussineau ha scritto: > This fixes the following assert when -device adlib is used: > ioport.c:240: portio_list_add: Assertion `pio->offset >= off_last' failed. > > Signed-off-by: Hervé Poussineau > --- > hw/audio/adlib.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/audio/adlib.c b/hw/audio/adlib.c > index 0421d47..db4a953 100644 > --- a/hw/audio/adlib.c > +++ b/hw/audio/adlib.c > @@ -284,9 +284,9 @@ static void Adlib_fini (AdlibState *s) > } > > static MemoryRegionPortio adlib_portio_list[] = { > - { 0x388, 4, 1, .read = adlib_read, .write = adlib_write, }, > { 0, 4, 1, .read = adlib_read, .write = adlib_write, }, > { 0, 2, 1, .read = adlib_read, .write = adlib_write, }, > + { 0x388, 4, 1, .read = adlib_read, .write = adlib_write, }, > PORTIO_END_OF_LIST(), > }; > > Ping, and Cc to qemu-stable