Re: [Qemu-devel] PING Re: [PATCH for-1.6] isa: fix documentation of isa_register_portio_list

["Andreas Färber" <afaerber@suse.de>]

Am 30.08.2013 18:02, schrieb Paolo Bonzini:
> Il 30/08/2013 17:56, Andreas Färber ha scritto:
>> Am 30.08.2013 17:45, schrieb Paolo Bonzini:
>>> Il 13/08/2013 12:38, Hervé Poussineau ha scritto:
>>>>
>>>> Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
>>>> ---
>>>>  include/hw/isa/isa.h |    2 +-
>>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/include/hw/isa/isa.h b/include/hw/isa/isa.h
>>>> index 495bcf3..fa45a5b 100644
>>>> --- a/include/hw/isa/isa.h
>>>> +++ b/include/hw/isa/isa.h
>>>> @@ -78,7 +78,7 @@ void isa_register_ioport(ISADevice *dev, MemoryRegion *io, uint16_t start);
>>>>   * @dev: the ISADevice against which these are registered; may be NULL.
>>>>   * @start: the base I/O port against which the portio->offset is applied.
>>>>   * @portio: the ports, sorted by offset.
>>>> - * @opaque: passed into the old_portio callbacks.
>>>> + * @opaque: passed into the portio callbacks.
>>>>   * @name: passed into memory_region_init_io.
>>>>   */
>>>>  void isa_register_portio_list(ISADevice *dev, uint16_t start,
>>>>
>>>
>>> Ping.
>>
>> If you actually give it a Reviewed-by I can take it through qom-next.
>>
>> Commit message does not point to a commit X for trivial verification
>> that it is in fact correct since X.
> 
> Commit b40acf9 (ioport: Switch dispatching to memory core layer,
> 2013-06-24) removed all instances of old_portio

Thanks, I've copied it into the commit message and consider this an
Acked-by. Applied to qom-next:
https://github.com/afaerber/qemu-cpu/commits/qom-next

Andreas

> except this, one in
> docs/memory.txt, and one in hw/ppc/spapr_pci.c.
> 
> Paolo
> 


-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg