qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <rth@twiddle.net>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] target-i386: fix disassembly with PAE=1, PG=0
Date: Fri, 30 Aug 2013 10:50:11 -0700	[thread overview]
Message-ID: <5220DB53.1020707@twiddle.net> (raw)
In-Reply-To: <1377856725-32644-1-git-send-email-pbonzini@redhat.com>

On 08/30/2013 02:58 AM, Paolo Bonzini wrote:
> CR4.PAE=1 will not enable paging if CR0.PG=0, but the "if" chain
> in x86_cpu_get_phys_page_debug says otherwise.  Check CR0.PG
> before everything else.
> 
> Fixes "-d in_asm" for a code section at the beginning of OVMF.
> 
> Cc: Richard Henderson <rth@twiddle.net>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Reviewed-by: Richard Henderson <rth@twiddle.net>



r~

  parent reply	other threads:[~2013-08-30 17:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-30  9:58 [Qemu-devel] [PATCH] target-i386: fix disassembly with PAE=1, PG=0 Paolo Bonzini
2013-08-30 10:05 ` Paolo Bonzini
2013-08-30 17:50 ` Richard Henderson [this message]
2013-08-30 18:03 ` Max Filippov
2013-09-12 17:53 ` [Qemu-devel] ping " Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5220DB53.1020707@twiddle.net \
    --to=rth@twiddle.net \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).