From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41703) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VFSpy-0001SH-9b for qemu-devel@nongnu.org; Fri, 30 Aug 2013 13:50:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VFSpt-0000Cm-2p for qemu-devel@nongnu.org; Fri, 30 Aug 2013 13:50:22 -0400 Received: from mail-ve0-x234.google.com ([2607:f8b0:400c:c01::234]:33101) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VFSps-0000Cf-UC for qemu-devel@nongnu.org; Fri, 30 Aug 2013 13:50:16 -0400 Received: by mail-ve0-f180.google.com with SMTP id pb11so1534061veb.25 for ; Fri, 30 Aug 2013 10:50:16 -0700 (PDT) Sender: Richard Henderson Message-ID: <5220DB53.1020707@twiddle.net> Date: Fri, 30 Aug 2013 10:50:11 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1377856725-32644-1-git-send-email-pbonzini@redhat.com> In-Reply-To: <1377856725-32644-1-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] target-i386: fix disassembly with PAE=1, PG=0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org On 08/30/2013 02:58 AM, Paolo Bonzini wrote: > CR4.PAE=1 will not enable paging if CR0.PG=0, but the "if" chain > in x86_cpu_get_phys_page_debug says otherwise. Check CR0.PG > before everything else. > > Fixes "-d in_asm" for a code section at the beginning of OVMF. > > Cc: Richard Henderson > Signed-off-by: Paolo Bonzini Reviewed-by: Richard Henderson r~