From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41397) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VFVCY-00038k-K2 for qemu-devel@nongnu.org; Fri, 30 Aug 2013 16:21:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VFVCU-0000Km-BE for qemu-devel@nongnu.org; Fri, 30 Aug 2013 16:21:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44017) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VFVCU-0000Kc-3L for qemu-devel@nongnu.org; Fri, 30 Aug 2013 16:21:46 -0400 Message-ID: <5220FED4.6040801@redhat.com> Date: Fri, 30 Aug 2013 14:21:40 -0600 From: Eric Blake MIME-Version: 1.0 References: <1377873389-9712-1-git-send-email-benoit@irqsave.net> <1377873389-9712-5-git-send-email-benoit@irqsave.net> In-Reply-To: <1377873389-9712-5-git-send-email-benoit@irqsave.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="6wRBETGSSA735FCPkHuc9jlaM2BmVa2dx" Subject: Re: [Qemu-devel] [PATCH V8 4/5] block: Add support for throttling burst max in QMP and the command line. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QmVub8OudCBDYW5ldA==?= Cc: kwolf@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, stefanha@redhat.com, pbonzini@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --6wRBETGSSA735FCPkHuc9jlaM2BmVa2dx Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/30/2013 08:36 AM, Beno=C3=AEt Canet wrote: > The max parameter of the leaky bucket throttling algorithm can be used = to > allow the guest to do bursts. > The max value is a pool of I/O that the guest can use without being thr= ottled > at all. Throttling is triggered once this pool is empty. >=20 > Signed-off-by: Benoit Canet > --- > @@ -1404,10 +1404,16 @@ Arguments: > - "device": device name (json-string) > - "bps": total throughput limit in bytes per second(json-int) > - "bps_rd": read throughput limit in bytes per second(json-int) > -- "bps_wr": read throughput limit in bytes per second(json-int) > +- "bps_wr": write throughput limit in bytes per second (json-int) It's odd that you are fixing one pre-existing case of missing space, but not all of them. Should we split the cleanups into a separate patch? I already started some cleanups[1], but could respin my patch to cover more, if desired. > @@ -1417,7 +1423,13 @@ Example: > "bps_wr": "0", > "iops": "0", > "iops_rd": "0", > - "iops_wr": "0" } } > + "iops_wr": "0", Depending on whether my patch[1] goes in first, fix this to use '0' instead of '"0"'. [1] still waiting for it to hit https://lists.gnu.org/archive/html/qemu-devel/2013-08/threads.html, but message id <1377891353-10682-1-git-send-email-eblake@redhat.com> [PATCH] qmp: fix integer usage in examples --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --6wRBETGSSA735FCPkHuc9jlaM2BmVa2dx Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSIP7UAAoJEKeha0olJ0Nqc+wH/iTo1CmqbxPbJ7wrvhTWah+i MJ7w8hvP7l0woA6znImOtnn8HURWqTm5eCwZIsC7rEksZw2I44AGm/yxyskRrlfa RKN0NvF0vgBUZk5AirTmXWlZD/0U67+Y0+x7qZz0EMZOzPGhxHKEctKUjFvoZflA 0we4kLkwmfKTfDL9k4AT9phn6e4s1L2QRb8I6vPaLdaQGvkO6xHLJMDlDeYSPPTx lazAZulpweEa7hEnprhfqVN3PVTSt0K3A+9YKZDUWwo/S9vLxqI2XwwnwSaaRpen M91yf8zgxwH5BqSS5IgsXxCD23B80l1pimTR6vdXEC8azy/kegnGfoNudwL0G8o= =M/NT -----END PGP SIGNATURE----- --6wRBETGSSA735FCPkHuc9jlaM2BmVa2dx--