From: Eric Blake <eblake@redhat.com>
To: "Benoît Canet" <benoit.canet@irqsave.net>
Cc: kwolf@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org,
stefanha@redhat.com, pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH V8 4/5] block: Add support for throttling burst max in QMP and the command line.
Date: Fri, 30 Aug 2013 14:39:24 -0600 [thread overview]
Message-ID: <522102FC.2010903@redhat.com> (raw)
In-Reply-To: <20130830203735.GC5170@irqsave.net>
[-- Attachment #1: Type: text/plain, Size: 843 bytes --]
On 08/30/2013 02:37 PM, Benoît Canet wrote:
>>> @@ -1404,10 +1404,16 @@ Arguments:
>>> - "device": device name (json-string)
>>> - "bps": total throughput limit in bytes per second(json-int)
>>> - "bps_rd": read throughput limit in bytes per second(json-int)
>>> -- "bps_wr": read throughput limit in bytes per second(json-int)
>>> +- "bps_wr": write throughput limit in bytes per second (json-int)
>
> I though that fixing coding style related issues in lines non directly impacted by a
> patch was bad so I changed only this one. The funny thing is that it propagate
> the scope of the patch.
Indeed, which is why I don't mind respinning my patch to do ALL the
cleanup in one go, as it's own patch series.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]
next prev parent reply other threads:[~2013-08-30 20:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-30 14:36 [Qemu-devel] [PATCH V8 0/5] Continuous Leaky Bucket Throttling Benoît Canet
2013-08-30 14:36 ` [Qemu-devel] [PATCH V8 1/5] throttle: Add a new throttling API implementing continuous leaky bucket Benoît Canet
2013-08-30 14:36 ` [Qemu-devel] [PATCH V8 2/5] throttle: Add units tests Benoît Canet
2013-08-30 14:36 ` [Qemu-devel] [PATCH V8 3/5] block: Enable the new throttling code in the block layer Benoît Canet
2013-08-30 14:36 ` [Qemu-devel] [PATCH V8 4/5] block: Add support for throttling burst max in QMP and the command line Benoît Canet
2013-08-30 20:21 ` Eric Blake
2013-08-30 20:37 ` Benoît Canet
2013-08-30 20:39 ` Eric Blake [this message]
2013-08-30 20:56 ` Benoît Canet
2013-08-30 14:36 ` [Qemu-devel] [PATCH V8 5/5] block: Add iops_size to do the iops accounting for a given io size Benoît Canet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=522102FC.2010903@redhat.com \
--to=eblake@redhat.com \
--cc=benoit.canet@irqsave.net \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).