From: "Andreas Färber" <afaerber@suse.de>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: Peter Crosthwaite <peter.crosthwaite@xilinx.com>,
Michael Walle <michael@walle.cc>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 2/2] milkymist-uart: use Device::realize instead of SysBusDevice::init
Date: Sat, 31 Aug 2013 21:09:20 +0200 [thread overview]
Message-ID: <52223F60.4000704@suse.de> (raw)
In-Reply-To: <1377969760-17489-3-git-send-email-antonynpavlov@gmail.com>
Am 31.08.2013 19:22, schrieb Antony Pavlov:
> Use of SysBusDevice::init is deprecated.
> Use Device::realize instead of SysBusDevice::init.
> Check dma/pl330.c for an example of the pattern.
>
> Also introduce TypeInfo::instance_init milkymist_uart_init()
> as char/pl011.c does.
>
> Reported-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> CC: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
> CC: Michael Walle <michael@walle.cc>
> CC: Andreas Färber <afaerber@suse.de>
> ---
> hw/char/milkymist-uart.c | 24 ++++++++++++++----------
> 1 file changed, 14 insertions(+), 10 deletions(-)
Thanks, applied to qom-next (with shortened commit message):
https://github.com/afaerber/qemu-cpu/commits/qom-next
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2013-08-31 19:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-31 17:22 [Qemu-devel] [PATCH v2 0/2] milkymist-uart fixes Antony Pavlov
2013-08-31 17:22 ` [Qemu-devel] [PATCH v2 1/2] milkymist-uart: use qemu_chr_fe_write_all() instead of qemu_chr_fe_write() Antony Pavlov
2013-09-01 22:58 ` Peter Crosthwaite
2013-09-17 17:24 ` Michael Walle
2013-09-02 15:39 ` Michael Walle
2013-08-31 17:22 ` [Qemu-devel] [PATCH v2 2/2] milkymist-uart: use Device::realize instead of SysBusDevice::init Antony Pavlov
2013-08-31 19:09 ` Andreas Färber [this message]
2013-09-01 18:28 ` Antony Pavlov
2013-09-02 7:53 ` Andreas Färber
2013-09-01 23:03 ` Peter Crosthwaite
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52223F60.4000704@suse.de \
--to=afaerber@suse.de \
--cc=antonynpavlov@gmail.com \
--cc=michael@walle.cc \
--cc=peter.crosthwaite@xilinx.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).