From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55192) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VFx4j-0006iS-Ds for qemu-devel@nongnu.org; Sat, 31 Aug 2013 22:07:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VFx4c-0002QM-6w for qemu-devel@nongnu.org; Sat, 31 Aug 2013 22:07:37 -0400 Received: from qmta15.emeryville.ca.mail.comcast.net ([76.96.27.228]:34866) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VFx4b-0002QB-SW for qemu-devel@nongnu.org; Sat, 31 Aug 2013 22:07:30 -0400 Message-ID: <5222A15E.10009@redhat.com> Date: Sat, 31 Aug 2013 20:07:26 -0600 From: Eric Blake MIME-Version: 1.0 References: In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="vbAqoI9cWqKPi3IuNnNGEexJOa2INxvUO" Subject: Re: [Qemu-devel] [PATCH] qapi-types.py: Fix enum struct sizes on i686 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cole Robinson Cc: Michael Roth , Luiz Capitulino , qemu-devel@nongnu.org, qemu-stable@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --vbAqoI9cWqKPi3IuNnNGEexJOa2INxvUO Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/31/2013 04:36 PM, Cole Robinson wrote: > Unlike other list types, enum wasn't adding any padding, which caused > a mismatch between the generated struct size and GenericList struct > size. More details in a678e26cbe89f7a27cbce794c2c2784571ee9d21 >=20 > This crashed qemu if calling qmp query-tpm-types for example, which > upsets libvirt capabilities probing. Reproducer on i686: >=20 > (sleep 5; printf '{"execute":"qmp_capabilities"}\n{"execute":"query-tpm= -types"}\n') | ./i386-softmmu/qemu-system-i386 -S -nodefaults -nographic = -M none -qmp stdio >=20 > https://bugs.launchpad.net/qemu/+bug/1219207 >=20 > Cc: qemu-stable@nongnu.org > Signed-off-by: Cole Robinson > --- > scripts/qapi-types.py | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) >=20 Reviewed-by: Eric Blake > - %(name)s value; > + union { > + %(name)s value; > + uint64_t padding; > + }; Am I right that anonymous unions are only a C11 feature (not C99)? But you are just copying and pasting from the other uses in this file, so it's not a problem. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --vbAqoI9cWqKPi3IuNnNGEexJOa2INxvUO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSIqFeAAoJEKeha0olJ0NqY/sIAIuXEO3uI7uFBj0mhti+AY61 80Je+eNr9gibP4rcLDYAWBFY1oXgHiGvnmR++pbfBWglRkIuOH8yC0cPZ4BdKNIl REqglJj8SqBA52GdX6ZLoitxyx2k9dIbwhP7JUUushIAFdbTmzq5CSRSQbfdWG1K VOBr+9Ze9qL0ydKcWi+6O/nNGuRS5WC0IckSdieRPM76IpJ0jNxhfg1MrUN9wIOq jjpW9mJLobaKhW6gxzUMhAaa3U1pGm2mRqWsMvt2l5MR5ZVgYtgEuqnxBiC8gHf2 Dut+BcVZRvRqNPrd5jzfWPe+YqzAKc+bNOECO5JZOFUy6fEJY9rVNTwHmsZ4li4= =1EoU -----END PGP SIGNATURE----- --vbAqoI9cWqKPi3IuNnNGEexJOa2INxvUO--