From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46695) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VGJCx-00037a-Rs for qemu-devel@nongnu.org; Sun, 01 Sep 2013 21:45:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VGJCl-0001WH-UD for qemu-devel@nongnu.org; Sun, 01 Sep 2013 21:45:35 -0400 Received: from e23smtp07.au.ibm.com ([202.81.31.140]:58127) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VGJCl-0001DY-AQ for qemu-devel@nongnu.org; Sun, 01 Sep 2013 21:45:23 -0400 Received: from /spool/local by e23smtp07.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 2 Sep 2013 11:31:05 +1000 Received: from d23relay05.au.ibm.com (d23relay05.au.ibm.com [9.190.235.152]) by d23dlp03.au.ibm.com (Postfix) with ESMTP id B14B73578053 for ; Mon, 2 Sep 2013 11:44:54 +1000 (EST) Received: from d23av02.au.ibm.com (d23av02.au.ibm.com [9.190.235.138]) by d23relay05.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r821SV8k10944852 for ; Mon, 2 Sep 2013 11:28:34 +1000 Received: from d23av02.au.ibm.com (localhost [127.0.0.1]) by d23av02.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id r821ipem013288 for ; Mon, 2 Sep 2013 11:44:51 +1000 Message-ID: <5223ED7F.8080208@linux.vnet.ibm.com> Date: Mon, 02 Sep 2013 09:44:31 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1375844419-7665-1-git-send-email-xiawenc@linux.vnet.ibm.com> <20130816153604.GB24852@stefanha-thinkpad.redhat.com> In-Reply-To: <20130816153604.GB24852@stefanha-thinkpad.redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH V7 0/8] add internal snapshot support at block device level List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Kevin Wolf , phrdina@redhat.com, famz@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com, lcapitulino@redhat.com, stefanha@redhat.com, pbonzini@redhat.com, dietmar@proxmox.com 于 2013-8-16 23:36, Stefan Hajnoczi 写道: > On Wed, Aug 07, 2013 at 11:00:11AM +0800, Wenchao Xia wrote: >> v6: >> Address Stefan's comments: >> 2/8: macro STR_PRINT_CHAR was renamed as STR_OR_NULL, and moved into patch 5, >> since implement function in this patch do not printf snapshot id any more, as >> Kevin's suggestion. > > Great. > >> Address Kevin's comments: >> 2/8: remove device, id, name info in the error message, use error message in >> existing caller. A new function bdrv_snapshot_delete_by_id_or_name() is added >> to make the usage clear while keep logic unchanged. >> 3/8: remove device info in error message when name is empty. Use else if >> after call of bdrv_snapshot_find_by_id_and_name(). >> Other: >> 2/8: refined the comments in code for bdrv_snapshot_delete(). >> 3/8: in error reporting, change format from "reason is: '%s'" to >> "reason is: %s". > > Kevin: do you have time to review these changes? > > Stefan > Hi, Kevin Do you have comments for it? -- Best Regards Wenchao Xia