From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33011) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VGOwz-0000ZE-0p for qemu-devel@nongnu.org; Mon, 02 Sep 2013 03:53:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VGOwu-0003Kw-DB for qemu-devel@nongnu.org; Mon, 02 Sep 2013 03:53:28 -0400 Received: from cantor2.suse.de ([195.135.220.15]:39808 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VGOwu-0003Kj-6m for qemu-devel@nongnu.org; Mon, 02 Sep 2013 03:53:24 -0400 Message-ID: <522443EC.7060807@suse.de> Date: Mon, 02 Sep 2013 09:53:16 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1377969760-17489-1-git-send-email-antonynpavlov@gmail.com> <1377969760-17489-3-git-send-email-antonynpavlov@gmail.com> <52223F60.4000704@suse.de> <20130901222806.61dabd55adab6f0e75e452f8@gmail.com> In-Reply-To: <20130901222806.61dabd55adab6f0e75e452f8@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 2/2] milkymist-uart: use Device::realize instead of SysBusDevice::init List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Antony Pavlov Cc: Peter Crosthwaite , Michael Walle , qemu-devel@nongnu.org Am 01.09.2013 20:28, schrieb Antony Pavlov: > On Sat, 31 Aug 2013 21:09:20 +0200 > Andreas F=C3=A4rber wrote: >=20 >> Am 31.08.2013 19:22, schrieb Antony Pavlov: >>> Use of SysBusDevice::init is deprecated. >>> Use Device::realize instead of SysBusDevice::init. >>> Check dma/pl330.c for an example of the pattern. >>> >>> Also introduce TypeInfo::instance_init milkymist_uart_init() >>> as char/pl011.c does. >>> >>> Reported-by: Peter Crosthwaite >>> Signed-off-by: Antony Pavlov >>> CC: Peter Crosthwaite >>> CC: Michael Walle >>> CC: Andreas F=C3=A4rber >>> --- >>> hw/char/milkymist-uart.c | 24 ++++++++++++++---------- >>> 1 file changed, 14 insertions(+), 10 deletions(-) >> >> Thanks, applied to qom-next (with shortened commit message): >> https://github.com/afaerber/qemu-cpu/commits/qom-next >> >=20 > That's about the patch number 1 ( milkymist-uart: use qemu_chr_fe_write= _all() instead of qemu_chr_fe_write()) ? No, it's about patch 2, which I replied to. Patch 1 is not a QOM conversion but an unrelated bug fix - it can be handled either by the lm32 maintainer or by whomever takes care of the char layer these days (Anthony/Gerd). Regards, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg