From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36546)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1VGkn2-0006Mj-CK
	for qemu-devel@nongnu.org; Tue, 03 Sep 2013 03:12:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1VGkmx-0002i2-1w
	for qemu-devel@nongnu.org; Tue, 03 Sep 2013 03:12:40 -0400
Received: from mx1.redhat.com ([209.132.183.28]:39336)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1VGkmw-0002hx-Qg
	for qemu-devel@nongnu.org; Tue, 03 Sep 2013 03:12:34 -0400
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
	(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r837CXLH009320
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Tue, 3 Sep 2013 03:12:34 -0400
Message-ID: <52258BDF.8050401@redhat.com>
Date: Tue, 03 Sep 2013 09:12:31 +0200
From: Max Reitz <mreitz@redhat.com>
MIME-Version: 1.0
References: <1378116246-12855-1-git-send-email-mreitz@redhat.com>
	<1378116246-12855-6-git-send-email-mreitz@redhat.com>
	<20130902153620.GE3423@dhcp-200-207.str.redhat.com>
In-Reply-To: <20130902153620.GE3423@dhcp-200-207.str.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v4 5/5] qemu-iotest: qcow2 image option
	amendment
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>

Am 02.09.2013 17:36, schrieb Kevin Wolf:
> Am 02.09.2013 um 12:04 hat Max Reitz geschrieben:
>> Add tests for qemu-img amend on qcow2 image files.
>>
>> Signed-off-by: Max Reitz <mreitz@redhat.com>
>> ---
>>   tests/qemu-iotests/061     | 178 +++++++++++++++++++++++
>>   tests/qemu-iotests/061.out | 349 +++++++++++++++++++++++++++++++++++++++++++++
>>   tests/qemu-iotests/group   |   1 +
>>   3 files changed, 528 insertions(+)
>>   create mode 100755 tests/qemu-iotests/061
>>   create mode 100644 tests/qemu-iotests/061.out
>> +echo
>> +echo "=== Testing version upgrade and resize ==="
>> +echo
>> +IMGOPTS="compat=0.10" _make_test_img 64M
>> +$QEMU_IO -c "write -P 0x2a 42M 64k" "$TEST_IMG" | _filter_qemu_io
>> +./qcow2.py "$TEST_IMG" dump-header
>> +$QEMU_IMG amend -o "compat=1.1,lazy_refcounts=on,size=128M" "$TEST_IMG"
>> +./qcow2.py "$TEST_IMG" dump-header
>> +$QEMU_IO -c "read -P 0x2a 42M 64k" "$TEST_IMG" | _filter_qemu_io
>> +_check_test_img
> Your reference output isn't correct for this test: It expects a 64 MB
> image after the amend. Looks like there's a bug somewhere.
>
> Kevin
Oh, right, thanks for catching it!

Max