From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38482) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VGkvO-0001A5-9H for qemu-devel@nongnu.org; Tue, 03 Sep 2013 03:21:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VGkvF-0005kD-Ra for qemu-devel@nongnu.org; Tue, 03 Sep 2013 03:21:18 -0400 Received: from mail-ee0-x229.google.com ([2a00:1450:4013:c00::229]:49058) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VGkvF-0005jG-Jh for qemu-devel@nongnu.org; Tue, 03 Sep 2013 03:21:09 -0400 Received: by mail-ee0-f41.google.com with SMTP id d17so2796060eek.14 for ; Tue, 03 Sep 2013 00:21:08 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <52258DE2.80108@redhat.com> Date: Tue, 03 Sep 2013 09:21:06 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1378189680-11987-1-git-send-email-aurelien@aurel32.net> In-Reply-To: <1378189680-11987-1-git-send-email-aurelien@aurel32.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/4] tcg/optimize: fixes and improvements List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aurelien Jarno Cc: qemu-devel@nongnu.org, Richard Henderson Il 03/09/2013 08:27, Aurelien Jarno ha scritto: > This patchset first fixes known-zero bits optimization so that it is > actually used, and does some further optimizations for 32-bit ops and > unsigned loads. > > Aurelien Jarno (4): > tcg/optimize: fix know-zero bits optimization > tcg/optimize: fix known-zero bits for right shift ops > tcg/optimize: improve known-zero bits for 32-bit ops > tcg/optimize: add known-zero bits compute for load ops > > tcg/optimize.c | 48 +++++++++++++++++++++++++++++++++++++++++++----- > 1 file changed, 43 insertions(+), 5 deletions(-) > Commit message 1 is a bit misleading, because the optimization still works for quite a few cases involving constant and copy propagation. However, I had the same patch in my queue, so I can't deny that there is a problem. :) Two questions: 1) should patch 2 be CCed to qemu-stable? 2) should patches 1 and 2 be inverted to avoid triggering bugs? Paolo