From: Paolo Bonzini <pbonzini@redhat.com>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] kvm: fix traces to use %x instead of %d
Date: Tue, 03 Sep 2013 09:21:35 +0200 [thread overview]
Message-ID: <52258DFF.5070404@redhat.com> (raw)
In-Reply-To: <1378190626-21986-1-git-send-email-aik@ozlabs.ru>
Il 03/09/2013 08:43, Alexey Kardashevskiy ha scritto:
> KVM request types are normally defined using hex constants but QEMU traces
> print decimal values instead what is not very convinient.
>
> This changes the request type format from %d to %x.
>
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> ---
> trace-events | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/trace-events b/trace-events
> index 4574f29..24cf4d2 100644
> --- a/trace-events
> +++ b/trace-events
> @@ -1171,9 +1171,9 @@ virtio_ccw_new_device(int cssid, int ssid, int schid, int devno, const char *dev
> migrate_set_state(int new_state) "new state %d"
>
> # kvm-all.c
> -kvm_ioctl(int type, void *arg) "type %d, arg %p"
> -kvm_vm_ioctl(int type, void *arg) "type %d, arg %p"
> -kvm_vcpu_ioctl(int cpu_index, int type, void *arg) "cpu_index %d, type %d, arg %p"
> +kvm_ioctl(int type, void *arg) "type %x, arg %p"
> +kvm_vm_ioctl(int type, void *arg) "type %x, arg %p"
> +kvm_vcpu_ioctl(int cpu_index, int type, void *arg) "cpu_index %d, type %x, arg %p"
> kvm_run_exit(int cpu_index, uint32_t reason) "cpu_index %d, reason %d"
>
> # memory.c
>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
next prev parent reply other threads:[~2013-09-03 7:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-03 6:43 [Qemu-devel] [PATCH] kvm: fix traces to use %x instead of %d Alexey Kardashevskiy
2013-09-03 7:21 ` Paolo Bonzini [this message]
2013-09-03 9:47 ` Andreas Färber
2013-09-03 15:44 ` Alexey Kardashevskiy
2013-09-04 10:00 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52258DFF.5070404@redhat.com \
--to=pbonzini@redhat.com \
--cc=aik@ozlabs.ru \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).