From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38571)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VGkvm-0001So-Nc
	for qemu-devel@nongnu.org; Tue, 03 Sep 2013 03:21:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VGkvg-0005mX-SY
	for qemu-devel@nongnu.org; Tue, 03 Sep 2013 03:21:42 -0400
Received: from mail-ea0-x234.google.com ([2a00:1450:4013:c01::234]:47375)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VGkvg-0005mR-L2
	for qemu-devel@nongnu.org; Tue, 03 Sep 2013 03:21:36 -0400
Received: by mail-ea0-f180.google.com with SMTP id h10so2753446eaj.39
	for <qemu-devel@nongnu.org>; Tue, 03 Sep 2013 00:21:35 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <52258DFF.5070404@redhat.com>
Date: Tue, 03 Sep 2013 09:21:35 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1378190626-21986-1-git-send-email-aik@ozlabs.ru>
In-Reply-To: <1378190626-21986-1-git-send-email-aik@ozlabs.ru>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] kvm: fix traces to use %x instead of %d
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: qemu-devel@nongnu.org

Il 03/09/2013 08:43, Alexey Kardashevskiy ha scritto:
> KVM request types are normally defined using hex constants but QEMU traces
> print decimal values instead what is not very convinient.
> 
> This changes the request type format from %d to %x.
> 
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> ---
>  trace-events | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/trace-events b/trace-events
> index 4574f29..24cf4d2 100644
> --- a/trace-events
> +++ b/trace-events
> @@ -1171,9 +1171,9 @@ virtio_ccw_new_device(int cssid, int ssid, int schid, int devno, const char *dev
>  migrate_set_state(int new_state) "new state %d"
>  
>  # kvm-all.c
> -kvm_ioctl(int type, void *arg) "type %d, arg %p"
> -kvm_vm_ioctl(int type, void *arg) "type %d, arg %p"
> -kvm_vcpu_ioctl(int cpu_index, int type, void *arg) "cpu_index %d, type %d, arg %p"
> +kvm_ioctl(int type, void *arg) "type %x, arg %p"
> +kvm_vm_ioctl(int type, void *arg) "type %x, arg %p"
> +kvm_vcpu_ioctl(int cpu_index, int type, void *arg) "cpu_index %d, type %x, arg %p"
>  kvm_run_exit(int cpu_index, uint32_t reason) "cpu_index %d, reason %d"
>  
>  # memory.c
> 

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>