* Re: [Qemu-devel] [PATCH] kvm: fix traces to use %x instead of %d
2013-09-03 6:43 [Qemu-devel] [PATCH] kvm: fix traces to use %x instead of %d Alexey Kardashevskiy
@ 2013-09-03 7:21 ` Paolo Bonzini
2013-09-03 9:47 ` Andreas Färber
2013-09-04 10:00 ` Stefan Hajnoczi
2 siblings, 0 replies; 5+ messages in thread
From: Paolo Bonzini @ 2013-09-03 7:21 UTC (permalink / raw)
To: Alexey Kardashevskiy; +Cc: qemu-devel
Il 03/09/2013 08:43, Alexey Kardashevskiy ha scritto:
> KVM request types are normally defined using hex constants but QEMU traces
> print decimal values instead what is not very convinient.
>
> This changes the request type format from %d to %x.
>
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> ---
> trace-events | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/trace-events b/trace-events
> index 4574f29..24cf4d2 100644
> --- a/trace-events
> +++ b/trace-events
> @@ -1171,9 +1171,9 @@ virtio_ccw_new_device(int cssid, int ssid, int schid, int devno, const char *dev
> migrate_set_state(int new_state) "new state %d"
>
> # kvm-all.c
> -kvm_ioctl(int type, void *arg) "type %d, arg %p"
> -kvm_vm_ioctl(int type, void *arg) "type %d, arg %p"
> -kvm_vcpu_ioctl(int cpu_index, int type, void *arg) "cpu_index %d, type %d, arg %p"
> +kvm_ioctl(int type, void *arg) "type %x, arg %p"
> +kvm_vm_ioctl(int type, void *arg) "type %x, arg %p"
> +kvm_vcpu_ioctl(int cpu_index, int type, void *arg) "cpu_index %d, type %x, arg %p"
> kvm_run_exit(int cpu_index, uint32_t reason) "cpu_index %d, reason %d"
>
> # memory.c
>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] kvm: fix traces to use %x instead of %d
2013-09-03 6:43 [Qemu-devel] [PATCH] kvm: fix traces to use %x instead of %d Alexey Kardashevskiy
2013-09-03 7:21 ` Paolo Bonzini
@ 2013-09-03 9:47 ` Andreas Färber
2013-09-03 15:44 ` Alexey Kardashevskiy
2013-09-04 10:00 ` Stefan Hajnoczi
2 siblings, 1 reply; 5+ messages in thread
From: Andreas Färber @ 2013-09-03 9:47 UTC (permalink / raw)
To: Alexey Kardashevskiy, Paolo Bonzini; +Cc: qemu-devel
Am 03.09.2013 08:43, schrieb Alexey Kardashevskiy:
> KVM request types are normally defined using hex constants but QEMU traces
> print decimal values instead what is not very convinient.
"which is", "convenient" -- pointing it out early since the KVM guys
don't fix patches once in their queue.
Patch itself:
Reviewed-by: Andreas Färber <afaerber@suse.de>
Andreas
>
> This changes the request type format from %d to %x.
>
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> ---
> trace-events | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/trace-events b/trace-events
> index 4574f29..24cf4d2 100644
> --- a/trace-events
> +++ b/trace-events
> @@ -1171,9 +1171,9 @@ virtio_ccw_new_device(int cssid, int ssid, int schid, int devno, const char *dev
> migrate_set_state(int new_state) "new state %d"
>
> # kvm-all.c
> -kvm_ioctl(int type, void *arg) "type %d, arg %p"
> -kvm_vm_ioctl(int type, void *arg) "type %d, arg %p"
> -kvm_vcpu_ioctl(int cpu_index, int type, void *arg) "cpu_index %d, type %d, arg %p"
> +kvm_ioctl(int type, void *arg) "type %x, arg %p"
> +kvm_vm_ioctl(int type, void *arg) "type %x, arg %p"
> +kvm_vcpu_ioctl(int cpu_index, int type, void *arg) "cpu_index %d, type %x, arg %p"
> kvm_run_exit(int cpu_index, uint32_t reason) "cpu_index %d, reason %d"
>
> # memory.c
>
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] kvm: fix traces to use %x instead of %d
2013-09-03 9:47 ` Andreas Färber
@ 2013-09-03 15:44 ` Alexey Kardashevskiy
0 siblings, 0 replies; 5+ messages in thread
From: Alexey Kardashevskiy @ 2013-09-03 15:44 UTC (permalink / raw)
To: Andreas Färber; +Cc: Paolo Bonzini, qemu-devel
On 09/03/2013 07:47 PM, Andreas Färber wrote:
> Am 03.09.2013 08:43, schrieb Alexey Kardashevskiy:
>> KVM request types are normally defined using hex constants but QEMU traces
>> print decimal values instead what is not very convinient.
>
> "which is", "convenient" -- pointing it out early since the KVM guys
> don't fix patches once in their queue.
Sorry, I did not get this. There is a patch like me in a queue?
> Patch itself:
>
> Reviewed-by: Andreas Färber <afaerber@suse.de>
Thanks!
> Andreas
>
>>
>> This changes the request type format from %d to %x.
>>
>> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
>> ---
>> trace-events | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/trace-events b/trace-events
>> index 4574f29..24cf4d2 100644
>> --- a/trace-events
>> +++ b/trace-events
>> @@ -1171,9 +1171,9 @@ virtio_ccw_new_device(int cssid, int ssid, int schid, int devno, const char *dev
>> migrate_set_state(int new_state) "new state %d"
>>
>> # kvm-all.c
>> -kvm_ioctl(int type, void *arg) "type %d, arg %p"
>> -kvm_vm_ioctl(int type, void *arg) "type %d, arg %p"
>> -kvm_vcpu_ioctl(int cpu_index, int type, void *arg) "cpu_index %d, type %d, arg %p"
>> +kvm_ioctl(int type, void *arg) "type %x, arg %p"
>> +kvm_vm_ioctl(int type, void *arg) "type %x, arg %p"
>> +kvm_vcpu_ioctl(int cpu_index, int type, void *arg) "cpu_index %d, type %x, arg %p"
>> kvm_run_exit(int cpu_index, uint32_t reason) "cpu_index %d, reason %d"
>>
>> # memory.c
>>
>
>
--
Alexey
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] kvm: fix traces to use %x instead of %d
2013-09-03 6:43 [Qemu-devel] [PATCH] kvm: fix traces to use %x instead of %d Alexey Kardashevskiy
2013-09-03 7:21 ` Paolo Bonzini
2013-09-03 9:47 ` Andreas Färber
@ 2013-09-04 10:00 ` Stefan Hajnoczi
2 siblings, 0 replies; 5+ messages in thread
From: Stefan Hajnoczi @ 2013-09-04 10:00 UTC (permalink / raw)
To: Alexey Kardashevskiy; +Cc: Paolo Bonzini, qemu-devel
On Tue, Sep 03, 2013 at 04:43:46PM +1000, Alexey Kardashevskiy wrote:
> KVM request types are normally defined using hex constants but QEMU traces
> print decimal values instead what is not very convinient.
>
> This changes the request type format from %d to %x.
>
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> ---
> trace-events | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/trace-events b/trace-events
> index 4574f29..24cf4d2 100644
> --- a/trace-events
> +++ b/trace-events
> @@ -1171,9 +1171,9 @@ virtio_ccw_new_device(int cssid, int ssid, int schid, int devno, const char *dev
> migrate_set_state(int new_state) "new state %d"
>
> # kvm-all.c
> -kvm_ioctl(int type, void *arg) "type %d, arg %p"
> -kvm_vm_ioctl(int type, void *arg) "type %d, arg %p"
> -kvm_vcpu_ioctl(int cpu_index, int type, void *arg) "cpu_index %d, type %d, arg %p"
> +kvm_ioctl(int type, void *arg) "type %x, arg %p"
> +kvm_vm_ioctl(int type, void *arg) "type %x, arg %p"
> +kvm_vcpu_ioctl(int cpu_index, int type, void *arg) "cpu_index %d, type %x, arg %p"
> kvm_run_exit(int cpu_index, uint32_t reason) "cpu_index %d, reason %d"
It would be confusing for someone using these trace events today if you
silently change the base to hex.
To avoid confusion I would use 0x%x or %#x. This way the output is
self-describing.
Stefan
^ permalink raw reply [flat|nested] 5+ messages in thread