From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53969) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VGm5s-0000xE-2A for qemu-devel@nongnu.org; Tue, 03 Sep 2013 04:36:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VGm5m-0002Oa-Ac for qemu-devel@nongnu.org; Tue, 03 Sep 2013 04:36:11 -0400 Message-ID: <52259F6E.3000205@suse.de> Date: Tue, 03 Sep 2013 10:35:58 +0200 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1378191917-6964-1-git-send-email-lig.fnst@cn.fujitsu.com> <52258E44.9010704@redhat.com> In-Reply-To: <52258E44.9010704@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] cputlb: remove dead function tlb_update_dirty List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Peter Maydell , qemu-trivial , Jan Kiszka , qemu-devel , Alexander Graf , liguang , Richard Henderson Am 03.09.2013 09:22, schrieb Paolo Bonzini: > Il 03/09/2013 09:05, liguang ha scritto: >> Signed-off-by: liguang >> --- >> cputlb.c | 15 --------------- >> 1 files changed, 0 insertions(+), 15 deletions(-) >> >> diff --git a/cputlb.c b/cputlb.c >> index 977c0ca..08e50e0 100644 >> --- a/cputlb.c >> +++ b/cputlb.c >> @@ -169,21 +169,6 @@ static inline ram_addr_t qemu_ram_addr_from_host_= nofail(void *ptr) >> return ram_addr; >> } >> =20 >> -static inline void tlb_update_dirty(CPUTLBEntry *tlb_entry) >> -{ >> - ram_addr_t ram_addr; >> - void *p; >> - >> - if (tlb_is_dirty_ram(tlb_entry)) { >> - p =3D (void *)(uintptr_t)((tlb_entry->addr_write & TARGET_PAG= E_MASK) >> - + tlb_entry->addend); >> - ram_addr =3D qemu_ram_addr_from_host_nofail(p); >> - if (!cpu_physical_memory_is_dirty(ram_addr)) { >> - tlb_entry->addr_write |=3D TLB_NOTDIRTY; >> - } >> - } >> -} >> - >> void cpu_tlb_reset_dirty_all(ram_addr_t start1, ram_addr_t length) >> { >> CPUState *cpu; >> >=20 > Reviewed-by: Paolo Bonzini >=20 > and CCing qemu-trivial. Negative, please keep qemu-trivial out of this. My qom-cpu pull was already blocked by the s390 and ppc pulls, so let's not add yet another potentially interfering one to the mix. IF rth agrees as TCG maintainer that this is not needed in any of his upcoming refactorings then I'll queue it on qom-cpu. My upcoming qom-cpu-13 series touches upon pretty much every core CPU file perceivable, including this cputlb.c. I also don't understand why qemu-trivial is suddenly picking up Stefan's arm translation patch, it used to be for unmaintained areas only. But arm is not my problem. Thanks, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg