From: "Andreas Färber" <afaerber@suse.de>
To: liguang <lig.fnst@cn.fujitsu.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
qemu-devel <qemu-devel@nongnu.org>,
Blue Swirl <blauwirbel@gmail.com>,
Anthony Liguori <anthony@codemonkey.ws>,
Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH] exec: avoid tcg_commit when kvm_enabled
Date: Tue, 03 Sep 2013 10:39:29 +0200 [thread overview]
Message-ID: <5225A041.6080001@suse.de> (raw)
In-Reply-To: <1378191564-6842-1-git-send-email-lig.fnst@cn.fujitsu.com>
Am 03.09.2013 08:59, schrieb liguang:
> Signed-off-by: liguang <lig.fnst@cn.fujitsu.com>
> ---
> exec.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/exec.c b/exec.c
> index 3ca9381..4509daa 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -1824,7 +1824,9 @@ static void memory_map_init(void)
> address_space_init(&address_space_io, system_io, "I/O");
>
> memory_listener_register(&core_memory_listener, &address_space_memory);
> - memory_listener_register(&tcg_memory_listener, &address_space_memory);
> + if (!kvm_enabled()) {
if (tcg_enabled())? I'm guessing Xen and QTest don't need it either?
Andreas
> + memory_listener_register(&tcg_memory_listener, &address_space_memory);
> + }
> }
>
> MemoryRegion *get_system_memory(void)
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2013-09-03 8:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-03 6:59 [Qemu-devel] [PATCH] exec: avoid tcg_commit when kvm_enabled liguang
2013-09-03 8:39 ` Andreas Färber [this message]
2013-09-04 1:07 ` Li Guang
2013-09-04 6:23 ` Paolo Bonzini
2013-09-04 6:30 ` Li Guang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5225A041.6080001@suse.de \
--to=afaerber@suse.de \
--cc=anthony@codemonkey.ws \
--cc=blauwirbel@gmail.com \
--cc=lig.fnst@cn.fujitsu.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=stefano.stabellini@eu.citrix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).