* [Qemu-devel] [PATCH] exec: avoid tcg_commit when kvm_enabled
@ 2013-09-03 6:59 liguang
2013-09-03 8:39 ` Andreas Färber
0 siblings, 1 reply; 5+ messages in thread
From: liguang @ 2013-09-03 6:59 UTC (permalink / raw)
To: qemu-devel
Cc: Peter Maydell, Blue Swirl, Paolo Bonzini, Andreas Färber,
liguang, Richard Henderson
Signed-off-by: liguang <lig.fnst@cn.fujitsu.com>
---
exec.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/exec.c b/exec.c
index 3ca9381..4509daa 100644
--- a/exec.c
+++ b/exec.c
@@ -1824,7 +1824,9 @@ static void memory_map_init(void)
address_space_init(&address_space_io, system_io, "I/O");
memory_listener_register(&core_memory_listener, &address_space_memory);
- memory_listener_register(&tcg_memory_listener, &address_space_memory);
+ if (!kvm_enabled()) {
+ memory_listener_register(&tcg_memory_listener, &address_space_memory);
+ }
}
MemoryRegion *get_system_memory(void)
--
1.7.2.5
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] exec: avoid tcg_commit when kvm_enabled
2013-09-03 6:59 [Qemu-devel] [PATCH] exec: avoid tcg_commit when kvm_enabled liguang
@ 2013-09-03 8:39 ` Andreas Färber
2013-09-04 1:07 ` Li Guang
0 siblings, 1 reply; 5+ messages in thread
From: Andreas Färber @ 2013-09-03 8:39 UTC (permalink / raw)
To: liguang
Cc: Peter Maydell, Stefano Stabellini, qemu-devel, Blue Swirl,
Anthony Liguori, Paolo Bonzini, Richard Henderson
Am 03.09.2013 08:59, schrieb liguang:
> Signed-off-by: liguang <lig.fnst@cn.fujitsu.com>
> ---
> exec.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/exec.c b/exec.c
> index 3ca9381..4509daa 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -1824,7 +1824,9 @@ static void memory_map_init(void)
> address_space_init(&address_space_io, system_io, "I/O");
>
> memory_listener_register(&core_memory_listener, &address_space_memory);
> - memory_listener_register(&tcg_memory_listener, &address_space_memory);
> + if (!kvm_enabled()) {
if (tcg_enabled())? I'm guessing Xen and QTest don't need it either?
Andreas
> + memory_listener_register(&tcg_memory_listener, &address_space_memory);
> + }
> }
>
> MemoryRegion *get_system_memory(void)
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] exec: avoid tcg_commit when kvm_enabled
2013-09-03 8:39 ` Andreas Färber
@ 2013-09-04 1:07 ` Li Guang
2013-09-04 6:23 ` Paolo Bonzini
0 siblings, 1 reply; 5+ messages in thread
From: Li Guang @ 2013-09-04 1:07 UTC (permalink / raw)
To: Andreas Färber
Cc: Peter Maydell, Stefano Stabellini, qemu-devel, Blue Swirl,
Anthony Liguori, Paolo Bonzini, Richard Henderson
在 2013-09-03二的 10:39 +0200，Andreas Färber写道：
> Am 03.09.2013 08:59, schrieb liguang:
> > Signed-off-by: liguang <lig.fnst@cn.fujitsu.com>
> > ---
> > exec.c | 4 +++-
> > 1 files changed, 3 insertions(+), 1 deletions(-)
> >
> > diff --git a/exec.c b/exec.c
> > index 3ca9381..4509daa 100644
> > --- a/exec.c
> > +++ b/exec.c
> > @@ -1824,7 +1824,9 @@ static void memory_map_init(void)
> > address_space_init(&address_space_io, system_io, "I/O");
> >
> > memory_listener_register(&core_memory_listener, &address_space_memory);
> > - memory_listener_register(&tcg_memory_listener, &address_space_memory);
> > + if (!kvm_enabled()) {
>
> if (tcg_enabled())? I'm guessing Xen and QTest don't need it either?
>
can't assure that currently,
anybody can help to assure whether Xen & QTest need tcg_commit?
>
> > + memory_listener_register(&tcg_memory_listener, &address_space_memory);
> > + }
> > }
> >
> > MemoryRegion *get_system_memory(void)
>
--
Thanks!
Li Guang
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] exec: avoid tcg_commit when kvm_enabled
2013-09-04 1:07 ` Li Guang
@ 2013-09-04 6:23 ` Paolo Bonzini
2013-09-04 6:30 ` Li Guang
0 siblings, 1 reply; 5+ messages in thread
From: Paolo Bonzini @ 2013-09-04 6:23 UTC (permalink / raw)
To: Li Guang
Cc: Peter Maydell, Stefano Stabellini, qemu-devel, Blue Swirl,
Anthony Liguori, Andreas Färber, Richard Henderson
Il 04/09/2013 03:07, Li Guang ha scritto:
> 在 2013-09-03二的 10:39 +0200，Andreas Färber写道：
>> Am 03.09.2013 08:59, schrieb liguang:
>>> Signed-off-by: liguang <lig.fnst@cn.fujitsu.com>
>>> ---
>>> exec.c | 4 +++-
>>> 1 files changed, 3 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/exec.c b/exec.c
>>> index 3ca9381..4509daa 100644
>>> --- a/exec.c
>>> +++ b/exec.c
>>> @@ -1824,7 +1824,9 @@ static void memory_map_init(void)
>>> address_space_init(&address_space_io, system_io, "I/O");
>>>
>>> memory_listener_register(&core_memory_listener, &address_space_memory);
>>> - memory_listener_register(&tcg_memory_listener, &address_space_memory);
>>> + if (!kvm_enabled()) {
>>
>> if (tcg_enabled())? I'm guessing Xen and QTest don't need it either?
>>
>
> can't assure that currently,
> anybody can help to assure whether Xen & QTest need tcg_commit?
No, they don't.
Paolo
>>
>>> + memory_listener_register(&tcg_memory_listener, &address_space_memory);
>>> + }
>>> }
>>>
>>> MemoryRegion *get_system_memory(void)
>>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] exec: avoid tcg_commit when kvm_enabled
2013-09-04 6:23 ` Paolo Bonzini
@ 2013-09-04 6:30 ` Li Guang
0 siblings, 0 replies; 5+ messages in thread
From: Li Guang @ 2013-09-04 6:30 UTC (permalink / raw)
To: Paolo Bonzini
Cc: Peter Maydell, Stefano Stabellini, qemu-devel, Blue Swirl,
Anthony Liguori, Andreas Färber, Richard Henderson
在 2013-09-04三的 08:23 +0200，Paolo Bonzini写道：
> Il 04/09/2013 03:07, Li Guang ha scritto:
> > 在 2013-09-03二的 10:39 +0200，Andreas Färber写道：
> >> Am 03.09.2013 08:59, schrieb liguang:
> >>> Signed-off-by: liguang <lig.fnst@cn.fujitsu.com>
> >>> ---
> >>> exec.c | 4 +++-
> >>> 1 files changed, 3 insertions(+), 1 deletions(-)
> >>>
> >>> diff --git a/exec.c b/exec.c
> >>> index 3ca9381..4509daa 100644
> >>> --- a/exec.c
> >>> +++ b/exec.c
> >>> @@ -1824,7 +1824,9 @@ static void memory_map_init(void)
> >>> address_space_init(&address_space_io, system_io, "I/O");
> >>>
> >>> memory_listener_register(&core_memory_listener, &address_space_memory);
> >>> - memory_listener_register(&tcg_memory_listener, &address_space_memory);
> >>> + if (!kvm_enabled()) {
> >>
> >> if (tcg_enabled())? I'm guessing Xen and QTest don't need it either?
> >>
> >
> > can't assure that currently,
> > anybody can help to assure whether Xen & QTest need tcg_commit?
>
OK, Thanks!
>
> >>
> >>> + memory_listener_register(&tcg_memory_listener, &address_space_memory);
> >>> + }
> >>> }
> >>>
> >>> MemoryRegion *get_system_memory(void)
> >>
> >
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-09-04 6:32 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-03 6:59 [Qemu-devel] [PATCH] exec: avoid tcg_commit when kvm_enabled liguang
2013-09-03 8:39 ` Andreas Färber
2013-09-04 1:07 ` Li Guang
2013-09-04 6:23 ` Paolo Bonzini
2013-09-04 6:30 ` Li Guang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).