From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41466)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1VGnD0-0000oc-Am
	for qemu-devel@nongnu.org; Tue, 03 Sep 2013 05:47:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1VGnCu-0006r9-Ua
	for qemu-devel@nongnu.org; Tue, 03 Sep 2013 05:47:38 -0400
Received: from cantor2.suse.de ([195.135.220.15]:54797 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1VGnCu-0006qx-Oh
	for qemu-devel@nongnu.org; Tue, 03 Sep 2013 05:47:32 -0400
Message-ID: <5225B030.3010307@suse.de>
Date: Tue, 03 Sep 2013 11:47:28 +0200
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1378190626-21986-1-git-send-email-aik@ozlabs.ru>
In-Reply-To: <1378190626-21986-1-git-send-email-aik@ozlabs.ru>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] kvm: fix traces to use %x instead of %d
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexey Kardashevskiy <aik@ozlabs.ru>, Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org

Am 03.09.2013 08:43, schrieb Alexey Kardashevskiy:
> KVM request types are normally defined using hex constants but QEMU tra=
ces
> print decimal values instead what is not very convinient.

"which is", "convenient" -- pointing it out early since the KVM guys
don't fix patches once in their queue.

Patch itself:

Reviewed-by: Andreas F=E4rber <afaerber@suse.de>

Andreas

>=20
> This changes the request type format from %d to %x.
>=20
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> ---
>  trace-events | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>=20
> diff --git a/trace-events b/trace-events
> index 4574f29..24cf4d2 100644
> --- a/trace-events
> +++ b/trace-events
> @@ -1171,9 +1171,9 @@ virtio_ccw_new_device(int cssid, int ssid, int sc=
hid, int devno, const char *dev
>  migrate_set_state(int new_state) "new state %d"
> =20
>  # kvm-all.c
> -kvm_ioctl(int type, void *arg) "type %d, arg %p"
> -kvm_vm_ioctl(int type, void *arg) "type %d, arg %p"
> -kvm_vcpu_ioctl(int cpu_index, int type, void *arg) "cpu_index %d, type=
 %d, arg %p"
> +kvm_ioctl(int type, void *arg) "type %x, arg %p"
> +kvm_vm_ioctl(int type, void *arg) "type %x, arg %p"
> +kvm_vcpu_ioctl(int cpu_index, int type, void *arg) "cpu_index %d, type=
 %x, arg %p"
>  kvm_run_exit(int cpu_index, uint32_t reason) "cpu_index %d, reason %d"
> =20
>  # memory.c
>=20


--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg