From: "Andreas Färber" <afaerber@suse.de>
To: Stefan Weil <sw@weilnetz.de>, Stefan Hajnoczi <stefanha@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Alexander Graf <agraf@suse.de>,
david.brenner3@gmail.com, qemu-stable@nongnu.org,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] w32: Fix access to host devices (regression)
Date: Tue, 03 Sep 2013 11:55:17 +0200 [thread overview]
Message-ID: <5225B205.9020900@suse.de> (raw)
In-Reply-To: <20130903085109.GE2683@dhcp-200-207.str.redhat.com>
Am 03.09.2013 10:51, schrieb Kevin Wolf:
> Am 01.09.2013 um 22:59 hat Stefan Weil geschrieben:
>> QEMU failed to open host devices like \\.\PhysicalDrive0 (first hard disk)
>> since some time (commit 8a79380b8ef1b02d2abd705dd026a18863b09020?).
>>
>> Those devices use hdev_open which did not use the latest API for options.
>> This resulted in a fatal runtime error:
>>
>> Block protocol 'host_device' doesn't support the option 'filename'
>>
>> Duplicate code from raw_open to fix this.
>>
>> Signed-off-by: Stefan Weil <sw@weilnetz.de>
>
> Reviewed-by: Kevin Wolf <kwolf@redhat.com>
>
>> ---
>>
>> This bug was reported by David Brenner.
>> It should be fixed in QEMU 1.6 as well.
>
> Cc: qemu-stable@nongnu.org
>
> (Ideally you'd also put this Cc line in your commit message.)
...and put the attribution as:
Reported-by: David Brenner <david.brenner3@gmail.com>
Maybe Stefan H. can still add that along with the Cc.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2013-09-03 9:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-01 20:59 [Qemu-devel] [PATCH] w32: Fix access to host devices (regression) Stefan Weil
2013-09-03 8:51 ` Kevin Wolf
2013-09-03 9:55 ` Andreas Färber [this message]
2013-09-03 9:48 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5225B205.9020900@suse.de \
--to=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=david.brenner3@gmail.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=stefanha@redhat.com \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).