From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56212)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VGoG4-0002VY-N7
	for qemu-devel@nongnu.org; Tue, 03 Sep 2013 06:54:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VGoG0-0001tY-Qm
	for qemu-devel@nongnu.org; Tue, 03 Sep 2013 06:54:52 -0400
Received: from mx1.redhat.com ([209.132.183.28]:17403)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VGoG0-0001tE-J7
	for qemu-devel@nongnu.org; Tue, 03 Sep 2013 06:54:48 -0400
Message-ID: <5225BFEB.7040606@redhat.com>
Date: Tue, 03 Sep 2013 12:54:35 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1377771676-6883-1-git-send-email-hutao@cn.fujitsu.com>
In-Reply-To: <1377771676-6883-1-git-send-email-hutao@cn.fujitsu.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] exec: check offset_within_address_space
 for register subpage
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Hu Tao <hutao@cn.fujitsu.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org, =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>, Richard Henderson <rth@twiddle.net>

Il 29/08/2013 12:21, Hu Tao ha scritto:
> If offset_within_address_space falls in a page, then we register a
> subpage. So check offset_within_address_space rather than
> offset_within_region.
>=20
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Richard Henderson <rth@twiddle.net>
> Cc: "Andreas F=C3=A4rber" <afaerber@suse.de>
> Cc: Peter Maydell <peter.maydell@linaro.org>
> Cc: Blue Swirl <blauwirbel@gmail.com>
> Signed-off-by: Hu Tao <hutao@cn.fujitsu.com>
> ---
>  exec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/exec.c b/exec.c
> index 3ca9381..f1f9151 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -869,7 +869,7 @@ static void mem_add(MemoryListener *listener, Memor=
yRegionSection *section)
>          now =3D remain;
>          if (int128_lt(remain.size, page_size)) {
>              register_subpage(d, &now);
> -        } else if (remain.offset_within_region & ~TARGET_PAGE_MASK) {
> +        } else if (remain.offset_within_address_space & ~TARGET_PAGE_M=
ASK) {
>              now.size =3D page_size;
>              register_subpage(d, &now);
>          } else {
>=20

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>