From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34032) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VGobq-0002je-Cz for qemu-devel@nongnu.org; Tue, 03 Sep 2013 07:17:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VGobi-0000Fi-0u for qemu-devel@nongnu.org; Tue, 03 Sep 2013 07:17:22 -0400 Received: from mail-qa0-x235.google.com ([2607:f8b0:400d:c00::235]:41300) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VGobh-0000Fc-T0 for qemu-devel@nongnu.org; Tue, 03 Sep 2013 07:17:13 -0400 Received: by mail-qa0-f53.google.com with SMTP id i13so1199222qae.5 for ; Tue, 03 Sep 2013 04:17:13 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <5225C537.1070109@redhat.com> Date: Tue, 03 Sep 2013 13:17:11 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1378105571-20570-1-git-send-email-pingfank@linux.vnet.ibm.com> In-Reply-To: <1378105571-20570-1-git-send-email-pingfank@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 0/3] bugs fix for hpet List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Liu Ping Fan Cc: Jan Kiszka , Stefan Hajnoczi , qemu-devel@nongnu.org, Anthony Liguori , =?ISO-8859-1?Q?Andreas_F=E4rber?= Il 02/09/2013 09:06, Liu Ping Fan ha scritto: > note: I rebase it onto Stefan's net-next tree, since pc-1.7 has already been defined there. > > v4: > use standard compat property to set hpet's interrupt compatibility > > v3: > change hpet interrupt capablity on board's demand > > > Liu Ping Fan (3): > hpet: inverse polarity when pin above ISA_NUM_IRQS > hpet: entitle more irq pins for hpet > pc-1.6: add compatibility for hpet intcap on pc-*-1.6 > > hw/timer/hpet.c | 27 +++++++++++++++++++++++---- > include/hw/i386/pc.h | 5 +++++ > 2 files changed, 28 insertions(+), 4 deletions(-) > Looks good. But I have one question; should this be changed for PIIX too, or should the 1.7 PIIX machine keep the old behavior? (I have no idea). Paolo