From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41658) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VGqpN-0000Pc-Co for qemu-devel@nongnu.org; Tue, 03 Sep 2013 09:39:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VGqpI-0001jY-GQ for qemu-devel@nongnu.org; Tue, 03 Sep 2013 09:39:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:14611) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VGqpI-0001jU-8a for qemu-devel@nongnu.org; Tue, 03 Sep 2013 09:39:24 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r83DdNMb004084 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 3 Sep 2013 09:39:23 -0400 Message-ID: <5225E68A.4090307@redhat.com> Date: Tue, 03 Sep 2013 07:39:22 -0600 From: Eric Blake MIME-Version: 1.0 References: <1378126884-9544-1-git-send-email-mreitz@redhat.com> In-Reply-To: <1378126884-9544-1-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="UFqCloGQBO2BR7cL0CAbF4vAMcoTRC6QK" Subject: Re: [Qemu-devel] [PATCH] qmp: Documentation for BLOCK_IMAGE_CORRUPTED List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: Kevin Wolf , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --UFqCloGQBO2BR7cL0CAbF4vAMcoTRC6QK Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/02/2013 07:01 AM, Max Reitz wrote: > Add an appropriate entry describing this event and its parameters into > qmp-events.txt. >=20 > Signed-off-by: Max Reitz > --- > Follow-up to: > - Add metadata overlap checks (series, v5); particularly patch 2 > (qcow2: Metadata overlap checks) > --- > QMP/qmp-events.txt | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) >=20 > diff --git a/QMP/qmp-events.txt b/QMP/qmp-events.txt > index 39b6016..6ff74d6 100644 > --- a/QMP/qmp-events.txt > +++ b/QMP/qmp-events.txt > @@ -478,3 +478,25 @@ Example: > =20 > { "event": "GUEST_PANICKED", > "data": { "action": "pause" } } > + > +BLOCK_IMAGE_CORRUPTED > +--------------------- The content is fine, but the location is not. We are trying to keep this file sorted by event name, so this belongs between BALLOON_CHANGE and BLOCK_IO_ERROR. As sorting is trivial, you can add this to your v2: Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --UFqCloGQBO2BR7cL0CAbF4vAMcoTRC6QK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSJeaKAAoJEKeha0olJ0Nq/yYIAIYRnAe5KMwoG7mXWXJnbXh0 I4VJivhEkrE3gVzpJoe9CfvKsfzsQ5oUd5UgSlflE8Fd5i54dJ8Uny55xqO5SasJ QNbGX/24IQ0O/r1ChHMtBOjG4k+rVYkD8uEck1Lq8TP6c50ojTI2cUcwS69wy5CO Tag20SphrktSmN7Mu7i5RVGCdWgiecdMvKhtY5JWWuuycHqgXnJq8rEQSMZSyZ6r jtbSZ0pNZke7MGvLpe2mJBqQ/mmL40w7OkFoM6NZkM7c8+iuDkrfRYe3xHzxvpYc 9q0MCq5UIuLW6RQCy/ggrppaVq88FTCKsdRc5CZTmPOkQncQfDJKLx58A2mgE6Y= =x6WQ -----END PGP SIGNATURE----- --UFqCloGQBO2BR7cL0CAbF4vAMcoTRC6QK--