From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45387) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VGr1C-0002Ac-Ml for qemu-devel@nongnu.org; Tue, 03 Sep 2013 09:51:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VGr15-0005ke-1Q for qemu-devel@nongnu.org; Tue, 03 Sep 2013 09:51:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:16339) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VGr14-0005kH-Qn for qemu-devel@nongnu.org; Tue, 03 Sep 2013 09:51:34 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r83DpX5i010416 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 3 Sep 2013 09:51:34 -0400 Message-ID: <5225E963.1020008@redhat.com> Date: Tue, 03 Sep 2013 15:51:31 +0200 From: Max Reitz MIME-Version: 1.0 References: <1378126884-9544-1-git-send-email-mreitz@redhat.com> <5225E68A.4090307@redhat.com> In-Reply-To: <5225E68A.4090307@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] qmp: Documentation for BLOCK_IMAGE_CORRUPTED List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Kevin Wolf , qemu-devel@nongnu.org On 2013-09-03 15:39, Eric Blake wrote: > On 09/02/2013 07:01 AM, Max Reitz wrote: >> Add an appropriate entry describing this event and its parameters into >> qmp-events.txt. >> >> Signed-off-by: Max Reitz >> --- >> Follow-up to: >> - Add metadata overlap checks (series, v5); particularly patch 2 >> (qcow2: Metadata overlap checks) >> --- >> QMP/qmp-events.txt | 22 ++++++++++++++++++++++ >> 1 file changed, 22 insertions(+) >> >> diff --git a/QMP/qmp-events.txt b/QMP/qmp-events.txt >> index 39b6016..6ff74d6 100644 >> --- a/QMP/qmp-events.txt >> +++ b/QMP/qmp-events.txt >> @@ -478,3 +478,25 @@ Example: >> >> { "event": "GUEST_PANICKED", >> "data": { "action": "pause" } } >> + >> +BLOCK_IMAGE_CORRUPTED >> +--------------------- > The content is fine, but the location is not. We are trying to keep > this file sorted by event name, so this belongs between BALLOON_CHANGE > and BLOCK_IO_ERROR. Okay, I was wondering about something like that, but the GUEST_PANICED at the end signaled to me there would be no such sorting. ;-) > As sorting is trivial, you can add this to your v2: > Reviewed-by: Eric Blake > Thank you, I just sent v2. Max