From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45593)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aik@ozlabs.ru>) id 1VGsmJ-0006nJ-6B
	for qemu-devel@nongnu.org; Tue, 03 Sep 2013 11:44:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aik@ozlabs.ru>) id 1VGsmD-0007nC-Ki
	for qemu-devel@nongnu.org; Tue, 03 Sep 2013 11:44:27 -0400
Received: from mail-pd0-f170.google.com ([209.85.192.170]:54841)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aik@ozlabs.ru>) id 1VGsmD-0007n5-Eb
	for qemu-devel@nongnu.org; Tue, 03 Sep 2013 11:44:21 -0400
Received: by mail-pd0-f170.google.com with SMTP id x10so6199324pdj.29
	for <qemu-devel@nongnu.org>; Tue, 03 Sep 2013 08:44:20 -0700 (PDT)
Message-ID: <522603CF.5010408@ozlabs.ru>
Date: Wed, 04 Sep 2013 01:44:15 +1000
From: Alexey Kardashevskiy <aik@ozlabs.ru>
MIME-Version: 1.0
References: <1378190626-21986-1-git-send-email-aik@ozlabs.ru>
	<5225B030.3010307@suse.de>
In-Reply-To: <5225B030.3010307@suse.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH] kvm: fix traces to use %x instead of %d
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org

On 09/03/2013 07:47 PM, Andreas Färber wrote:
> Am 03.09.2013 08:43, schrieb Alexey Kardashevskiy:
>> KVM request types are normally defined using hex constants but QEMU traces
>> print decimal values instead what is not very convinient.
> 
> "which is", "convenient" -- pointing it out early since the KVM guys
> don't fix patches once in their queue.

Sorry, I did not get this. There is a patch like me in a queue?


> Patch itself:
> 
> Reviewed-by: Andreas Färber <afaerber@suse.de>

Thanks!


> Andreas
> 
>>
>> This changes the request type format from %d to %x.
>>
>> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
>> ---
>>  trace-events | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/trace-events b/trace-events
>> index 4574f29..24cf4d2 100644
>> --- a/trace-events
>> +++ b/trace-events
>> @@ -1171,9 +1171,9 @@ virtio_ccw_new_device(int cssid, int ssid, int schid, int devno, const char *dev
>>  migrate_set_state(int new_state) "new state %d"
>>  
>>  # kvm-all.c
>> -kvm_ioctl(int type, void *arg) "type %d, arg %p"
>> -kvm_vm_ioctl(int type, void *arg) "type %d, arg %p"
>> -kvm_vcpu_ioctl(int cpu_index, int type, void *arg) "cpu_index %d, type %d, arg %p"
>> +kvm_ioctl(int type, void *arg) "type %x, arg %p"
>> +kvm_vm_ioctl(int type, void *arg) "type %x, arg %p"
>> +kvm_vcpu_ioctl(int cpu_index, int type, void *arg) "cpu_index %d, type %x, arg %p"
>>  kvm_run_exit(int cpu_index, uint32_t reason) "cpu_index %d, reason %d"
>>  
>>  # memory.c
>>
> 
> 


-- 
Alexey