From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56887) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VGuxF-00037F-Fp for qemu-devel@nongnu.org; Tue, 03 Sep 2013 14:04:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VGux6-0003hY-DF for qemu-devel@nongnu.org; Tue, 03 Sep 2013 14:03:53 -0400 Received: from e7.ny.us.ibm.com ([32.97.182.137]:55249) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VGux6-0003hA-7m for qemu-devel@nongnu.org; Tue, 03 Sep 2013 14:03:44 -0400 Received: from /spool/local by e7.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 3 Sep 2013 14:03:40 -0400 Received: from b01cxnp22035.gho.pok.ibm.com (b01cxnp22035.gho.pok.ibm.com [9.57.198.25]) by d01dlp02.pok.ibm.com (Postfix) with ESMTP id 8A72D6E8041 for ; Tue, 3 Sep 2013 14:03:37 -0400 (EDT) Received: from d01av05.pok.ibm.com (d01av05.pok.ibm.com [9.56.224.195]) by b01cxnp22035.gho.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r83I3alX13041674 for ; Tue, 3 Sep 2013 18:03:36 GMT Received: from d01av05.pok.ibm.com (loopback [127.0.0.1]) by d01av05.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r83I2ZRG004798 for ; Tue, 3 Sep 2013 14:02:36 -0400 Message-ID: <5226243B.6040001@linux.vnet.ibm.com> Date: Tue, 03 Sep 2013 14:02:35 -0400 From: Corey Bryant MIME-Version: 1.0 References: <1377738272-3470-1-git-send-email-otubo@linux.vnet.ibm.com> <20130829083411.GD23096@stefanha-thinkpad.redhat.com> <5220AA75.7080402@linux.vnet.ibm.com> In-Reply-To: <5220AA75.7080402@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] seccomp: adding a second whitelist List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Otubo Cc: pmoore@redhat.com, Stefan Hajnoczi , wad@chromium.org, qemu-devel@nongnu.org On 08/30/2013 10:21 AM, Eduardo Otubo wrote: > > > On 08/29/2013 05:34 AM, Stefan Hajnoczi wrote: >> On Wed, Aug 28, 2013 at 10:04:32PM -0300, Eduardo Otubo wrote: >>> Now there's a second whitelist, right before the vcpu starts. The second >>> whitelist is the same as the first one, except for exec() and select(). >> >> -netdev tap,downscript=/path/to/script requires exec() in the QEMU >> shutdown code path. Will this work with seccomp? > > I actually don't know, but I'll test that as well. Can you run a test > with this patch and -netdev? I mean, if you're pointing that out you > might have a scenario already setup, right? > > Thanks! > This uses exec() in net/tap.c. I think if we're going to introduce a sandbox environment that restricts existing QEMU behavior, then we have to introduce a new argument to the -sandbox option. So for example, "-sandbox on" would continue to use the whitelist that allows everything in QEMU to work (or at least it should :). And something like "-sandbox on,strict=on" would use the whitelist + blacklist. If this is acceptable though, then I wonder how we could go about adding new syscalls to the blacklist in future QEMU releases without regressing "-sandbox on,strict=on". By the way, are any test buckets running regularly with -sandbox on? -- Regards, Corey Bryant >> >> Stefan >> >