From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54412) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VGwrC-0004fg-O2 for qemu-devel@nongnu.org; Tue, 03 Sep 2013 16:05:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VGwr3-000848-Cp for qemu-devel@nongnu.org; Tue, 03 Sep 2013 16:05:46 -0400 Received: from e24smtp03.br.ibm.com ([32.104.18.24]:57788) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VGwr3-00083u-0p for qemu-devel@nongnu.org; Tue, 03 Sep 2013 16:05:37 -0400 Received: from /spool/local by e24smtp03.br.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 3 Sep 2013 17:05:33 -0300 Received: from d24relay02.br.ibm.com (d24relay02.br.ibm.com [9.13.184.26]) by d24dlp01.br.ibm.com (Postfix) with ESMTP id 097013520066 for ; Tue, 3 Sep 2013 16:05:32 -0400 (EDT) Received: from d24av03.br.ibm.com (d24av03.br.ibm.com [9.8.31.95]) by d24relay02.br.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r83K3mqf36175878 for ; Tue, 3 Sep 2013 17:03:48 -0300 Received: from d24av03.br.ibm.com (localhost [127.0.0.1]) by d24av03.br.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id r83K5UIQ011262 for ; Tue, 3 Sep 2013 17:05:31 -0300 Message-ID: <5226410A.6070705@linux.vnet.ibm.com> Date: Tue, 03 Sep 2013 17:05:30 -0300 From: Eduardo Otubo MIME-Version: 1.0 References: <1377738272-3470-1-git-send-email-otubo@linux.vnet.ibm.com> <20130829083411.GD23096@stefanha-thinkpad.redhat.com> <5220AA75.7080402@linux.vnet.ibm.com> <5226243B.6040001@linux.vnet.ibm.com> In-Reply-To: <5226243B.6040001@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] seccomp: adding a second whitelist List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Corey Bryant Cc: pmoore@redhat.com, Stefan Hajnoczi , wad@chromium.org, qemu-devel@nongnu.org On 09/03/2013 03:02 PM, Corey Bryant wrote: > > > On 08/30/2013 10:21 AM, Eduardo Otubo wrote: >> >> >> On 08/29/2013 05:34 AM, Stefan Hajnoczi wrote: >>> On Wed, Aug 28, 2013 at 10:04:32PM -0300, Eduardo Otubo wrote: >>>> Now there's a second whitelist, right before the vcpu starts. The >>>> second >>>> whitelist is the same as the first one, except for exec() and select(). >>> >>> -netdev tap,downscript=/path/to/script requires exec() in the QEMU >>> shutdown code path. Will this work with seccomp? >> >> I actually don't know, but I'll test that as well. Can you run a test >> with this patch and -netdev? I mean, if you're pointing that out you >> might have a scenario already setup, right? >> >> Thanks! >> > > This uses exec() in net/tap.c. > > I think if we're going to introduce a sandbox environment that restricts > existing QEMU behavior, then we have to introduce a new argument to the > -sandbox option. So for example, "-sandbox on" would continue to use > the whitelist that allows everything in QEMU to work (or at least it > should :). And something like "-sandbox on,strict=on" would use the > whitelist + blacklist. I think tihs is very reasonable. I'll working on implementing this options for v2. > > If this is acceptable though, then I wonder how we could go about adding > new syscalls to the blacklist in future QEMU releases without regressing > "-sandbox on,strict=on". > > By the way, are any test buckets running regularly with -sandbox on? I am running tests with virt-test. Need to come up with a script that checks for unused syscalls, though. -- Eduardo Otubo IBM Linux Technology Center