From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42803)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VH6VB-000439-4Y
	for qemu-devel@nongnu.org; Wed, 04 Sep 2013 02:23:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VH6V6-0001BD-52
	for qemu-devel@nongnu.org; Wed, 04 Sep 2013 02:23:41 -0400
Received: from mail-ea0-x236.google.com ([2a00:1450:4013:c01::236]:56821)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VH6V5-0001At-UX
	for qemu-devel@nongnu.org; Wed, 04 Sep 2013 02:23:36 -0400
Received: by mail-ea0-f182.google.com with SMTP id o10so3501225eaj.27
	for <qemu-devel@nongnu.org>; Tue, 03 Sep 2013 23:23:35 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <5226D1E6.4090502@redhat.com>
Date: Wed, 04 Sep 2013 08:23:34 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1378191564-6842-1-git-send-email-lig.fnst@cn.fujitsu.com>
	<5225A041.6080001@suse.de>
	<1378256863.12672.4.camel@liguang.fnst.cn.fujitsu.com>
In-Reply-To: <1378256863.12672.4.camel@liguang.fnst.cn.fujitsu.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH] exec: avoid tcg_commit when kvm_enabled
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Li Guang <lig.fnst@cn.fujitsu.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, qemu-devel <qemu-devel@nongnu.org>, Blue Swirl <blauwirbel@gmail.com>, Anthony Liguori <anthony@codemonkey.ws>, =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>, Richard Henderson <rth@twiddle.net>

Il 04/09/2013 03:07, Li Guang ha scritto:
> 在 2013-09-03二的 10:39 +0200，Andreas Färber写道：
>> Am 03.09.2013 08:59, schrieb liguang:
>>> Signed-off-by: liguang <lig.fnst@cn.fujitsu.com>
>>> ---
>>>  exec.c |    4 +++-
>>>  1 files changed, 3 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/exec.c b/exec.c
>>> index 3ca9381..4509daa 100644
>>> --- a/exec.c
>>> +++ b/exec.c
>>> @@ -1824,7 +1824,9 @@ static void memory_map_init(void)
>>>      address_space_init(&address_space_io, system_io, "I/O");
>>>  
>>>      memory_listener_register(&core_memory_listener, &address_space_memory);
>>> -    memory_listener_register(&tcg_memory_listener, &address_space_memory);
>>> +    if (!kvm_enabled()) {
>>
>> if (tcg_enabled())? I'm guessing Xen and QTest don't need it either?
>>
> 
> can't assure that currently, 
> anybody can help to assure whether Xen & QTest need tcg_commit?

No, they don't.

Paolo

>>
>>> +        memory_listener_register(&tcg_memory_listener, &address_space_memory);
>>> +    }
>>>  }
>>>  
>>>  MemoryRegion *get_system_memory(void)
>>
>