From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Hervé Poussineau" <hpoussin@reactos.org>,
"Andreas Färber" <andreas.faerber@web.de>,
"qemu-ppc@nongnu.org" <qemu-ppc@nongnu.org>,
"QEMU Developers" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v2 05/10] raven: set a correct PCI I/O memory region
Date: Wed, 04 Sep 2013 10:11:47 +0200 [thread overview]
Message-ID: <5226EB43.203@redhat.com> (raw)
In-Reply-To: <CAFEAcA_5FxE0PoFDQZWtd27tHLZKF4GcC1A9321+2XfL45zEgw@mail.gmail.com>
Il 04/09/2013 09:22, Peter Maydell ha scritto:
> > Not using address_space_io is fine as well, but it's a separate change
> > and I doubt it is a good idea to do it for a single target; if you do it
> > for all non-x86 PCI bridges, and move the initialization of
> > address_space_io to target-i386, that's a different story of course.
> What's the problem with doing it for a single target? That's
> what I did for versatilepb. I think any CPU that doesn't have
> inb/outb type instructions (x86 does, and I think also alpha
> but I forget)
Actually, Alpha is also not using address_space_io at all as far as I
can see.
> should not be using address_space_io; but the
> easiest way to get there is to convert the PCI bridges one at
> a time as we have maintenance effort to do so.
I'm not against the patch, but there are less than ten host bridges and
most of them should be tested by "make check", so I would prefer to have
a plan for making things consistent.
Paolo
next prev parent reply other threads:[~2013-09-04 8:12 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-03 22:29 [Qemu-devel] [PATCH v2 00/10] prep: improve Raven PCI host emulation Hervé Poussineau
2013-09-03 22:29 ` [Qemu-devel] [PATCH v2 01/10] prep: kill get_system_io() usage Hervé Poussineau
2013-09-04 6:13 ` Paolo Bonzini
2013-09-04 18:29 ` Hervé Poussineau
2013-09-03 22:29 ` [Qemu-devel] [PATCH v2 02/10] raven: use constant PCI_NUM_PINS instead of 4 Hervé Poussineau
2013-09-03 22:29 ` [Qemu-devel] [PATCH v2 03/10] raven: move BIOS loading from board code to PCI host Hervé Poussineau
2013-09-03 22:29 ` [Qemu-devel] [PATCH v2 04/10] raven: rename intack region to pci_intack Hervé Poussineau
2013-09-03 22:29 ` [Qemu-devel] [PATCH v2 05/10] raven: set a correct PCI I/O memory region Hervé Poussineau
2013-09-04 6:01 ` Paolo Bonzini
2013-09-04 7:22 ` Peter Maydell
2013-09-04 8:11 ` Paolo Bonzini [this message]
2013-09-04 8:25 ` Peter Maydell
2013-09-04 8:31 ` Paolo Bonzini
2013-09-04 8:51 ` Peter Maydell
2013-09-04 8:54 ` Andreas Färber
2013-09-09 20:57 ` Hervé Poussineau
2013-09-09 21:33 ` Peter Maydell
2013-09-10 7:43 ` Paolo Bonzini
2013-09-03 22:29 ` [Qemu-devel] [PATCH v2 06/10] raven: set a correct PCI " Hervé Poussineau
2013-09-03 22:29 ` [Qemu-devel] [PATCH v2 07/10] raven: add PCI bus mastering address space Hervé Poussineau
2013-09-03 22:29 ` [Qemu-devel] [PATCH v2 08/10] raven: implement non-contiguous I/O region Hervé Poussineau
2013-09-03 22:29 ` [Qemu-devel] [PATCH v2 09/10] raven: fix PCI bus accesses with size > 1 Hervé Poussineau
2013-09-03 22:29 ` [Qemu-devel] [PATCH v2 10/10] raven: use raven_ for all function prefixes Hervé Poussineau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5226EB43.203@redhat.com \
--to=pbonzini@redhat.com \
--cc=andreas.faerber@web.de \
--cc=hpoussin@reactos.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).