From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47718) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VHE3e-0007Jc-Dh for qemu-devel@nongnu.org; Wed, 04 Sep 2013 10:27:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VHE3W-0000sQ-00 for qemu-devel@nongnu.org; Wed, 04 Sep 2013 10:27:46 -0400 Received: from mail-qe0-x22c.google.com ([2607:f8b0:400d:c02::22c]:63902) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VHE3V-0000sL-RZ for qemu-devel@nongnu.org; Wed, 04 Sep 2013 10:27:37 -0400 Received: by mail-qe0-f44.google.com with SMTP id 5so171765qeb.17 for ; Wed, 04 Sep 2013 07:27:36 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <52274357.6010509@redhat.com> Date: Wed, 04 Sep 2013 16:27:35 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1378304540-1431-1-git-send-email-ottlik@fzi.de> In-Reply-To: <1378304540-1431-1-git-send-email-ottlik@fzi.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH RFC] Do not set SO_REUSEADDR on Windows List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Sebastian Ottlik Cc: Jan Kiszka , Anthony Liguori , qemu-devel@nongnu.org, Stefan Hajnoczi Il 04/09/2013 16:22, Sebastian Ottlik ha scritto: > This patchset disabels all use of SO_REUSEADDR on Windows. On Windows systems > the default behavior is equivalent to SO_REUSEADDR on other operating > systems. SO_REUSEADDR can still be set but results in undesired bahvior > instead. It may even lead to situations were system behavior is > unspecified. More information on this can be found at: > http://msdn.microsoft.com/en-us/library/windows/desktop/ms740621.aspx > > I originally encountered this issue when accidentally launching two QEMU > instances with identical GDB ports at the same time. In which case QEMU won't > fail as one might expect. I am sending this as RFC as I A) only checked that > this fixes issues for the GDB server and B) am not sure if this is the correct > format for this patchset. > > gdbstub: do not set SO_REUSEADDR on Windows > net: do not set SO_REUSEADDR on Windows > slirp: do not set SO_REUSEADDR on Windows > util: do not set SO_REUSEADDR on Windows Makes sense. Can you make a different patch that introduces a new function qemu_set_reuseaddr is include/qemu/sockets.h & util/oslib-*, and makes it a stub for Windows? This way we don't have a proliferation of #ifs. Paolo