From: Richard Henderson <rth@twiddle.net>
To: liguang <lig.fnst@cn.fujitsu.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>,
"Blue Swirl" <blauwirbel@gmail.com>,
"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH v2] exec: do tcg_commit only when tcg_enabled
Date: Wed, 04 Sep 2013 07:28:21 -0700 [thread overview]
Message-ID: <52274385.9060900@twiddle.net> (raw)
In-Reply-To: <1378276653-18311-1-git-send-email-lig.fnst@cn.fujitsu.com>
On 09/03/2013 11:37 PM, liguang wrote:
> Signed-off-by: liguang <lig.fnst@cn.fujitsu.com>
> ---
> exec.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/exec.c b/exec.c
> index 3ca9381..2170295 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -1824,7 +1824,9 @@ static void memory_map_init(void)
> address_space_init(&address_space_io, system_io, "I/O");
>
> memory_listener_register(&core_memory_listener, &address_space_memory);
> - memory_listener_register(&tcg_memory_listener, &address_space_memory);
> + if (tcg_enabled()) {
> + memory_listener_register(&tcg_memory_listener, &address_space_memory);
> + }
> }
>
> MemoryRegion *get_system_memory(void)
>
Reviewed-by: Richard Henderson <rth@twiddle.net>
r~
prev parent reply other threads:[~2013-09-04 14:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-04 6:37 [Qemu-devel] [PATCH v2] exec: do tcg_commit only when tcg_enabled liguang
2013-09-04 14:28 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52274385.9060900@twiddle.net \
--to=rth@twiddle.net \
--cc=afaerber@suse.de \
--cc=blauwirbel@gmail.com \
--cc=lig.fnst@cn.fujitsu.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).