From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46394) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VHHqJ-0003KP-9A for qemu-devel@nongnu.org; Wed, 04 Sep 2013 14:30:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VHHqB-0007jq-5K for qemu-devel@nongnu.org; Wed, 04 Sep 2013 14:30:15 -0400 Message-ID: <52277C1E.4060404@reactos.org> Date: Wed, 04 Sep 2013 20:29:50 +0200 From: =?UTF-8?B?SGVydsOpIFBvdXNzaW5lYXU=?= MIME-Version: 1.0 References: <1378247351-8446-1-git-send-email-hpoussin@reactos.org> <1378247351-8446-2-git-send-email-hpoussin@reactos.org> <5226CFA4.4070600@redhat.com> In-Reply-To: <5226CFA4.4070600@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 01/10] prep: kill get_system_io() usage List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , qemu-ppc@nongnu.org, qemu-devel@nongnu.org Paolo Bonzini a =C3=A9crit : > Il 04/09/2013 00:29, Herv=C3=A9 Poussineau ha scritto: >> While ISA address space in prep machine is currently the one returned >> by get_system_io(), this depends of the implementation of i82378/raven >> devices, and this may not be the case forever. >> >> Use the right ISA address space when adding some more ports to it. >> We can use whatever ISA device on the right ISA bus, as all ISA device= s >> on the same ISA bus share the same ISA address space. >> >> Signed-off-by: Herv=C3=A9 Poussineau >> --- >> hw/ppc/prep.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/hw/ppc/prep.c b/hw/ppc/prep.c >> index 7e04b1a..efc892d 100644 >> --- a/hw/ppc/prep.c >> +++ b/hw/ppc/prep.c >> @@ -656,7 +656,7 @@ static void ppc_prep_init(QEMUMachineInitArgs *arg= s) >> sysctrl->reset_irq =3D cpu->env.irq_inputs[PPC6xx_INPUT_HRESET]; >> =20 >> portio_list_init(port_list, NULL, prep_portio_list, sysctrl, "pre= p"); >> - portio_list_add(port_list, get_system_io(), 0x0); >> + portio_list_add(port_list, isa_address_space_io(isa), 0x0); >> =20 >> /* PowerPC control and status register group */ >> #if 0 >> >=20 > Should it be instead the I/O address space of the Raven instead > (pci_bus->address_space_io, or alternatively you could add a new > function)? Or if you make it the ISA address space, should this be a > new, full-blown ISA device? Yes, this should be replaced by a full-blow ISA device. However, this=20 patchset is for the raven PCI host, so I tried to do only minimal and=20 required changes in other parts. Regards, Herv=C3=A9