From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41D05C56201 for ; Thu, 19 Nov 2020 21:10:44 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9698722255 for ; Thu, 19 Nov 2020 21:10:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="EL4o3pt3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9698722255 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46936 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kfrCU-0004qY-LN for qemu-devel@archiver.kernel.org; Thu, 19 Nov 2020 16:10:42 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41640) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kfr8w-0000eR-Az for qemu-devel@nongnu.org; Thu, 19 Nov 2020 16:07:07 -0500 Received: from mail-pf1-x42e.google.com ([2607:f8b0:4864:20::42e]:40153) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kfr8t-0003XU-6c for qemu-devel@nongnu.org; Thu, 19 Nov 2020 16:07:02 -0500 Received: by mail-pf1-x42e.google.com with SMTP id w14so5685336pfd.7 for ; Thu, 19 Nov 2020 13:06:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=UDnKv70mEcOhhHuHyK23iNhbXNJ/iC7P3ksp9aZBr4E=; b=EL4o3pt3KA8zPq7yrifcJEDFu/q8+BzWENVzdFyXp0KEo3QEBij4UvDNk8iUj+ZeZ8 125QHu6wU1MTF8Rul/Jp8Kifttg4vcr6388ece0gO1BrIM97wCSPqTFwYE56culFiZzn P3THIF2fEpYxVkwSXjFyUhUZ3AoMkHZRrEV1Asy8ae0pVBy1rvXshn9rzkFHXHyJggE5 SXtF2fRHS4jmdp9MpAXxV4tR1W0ehGzOMaVk5wsSTMm9wtS5R0WhIhO8gchB8DXvx/VQ CF8wUseGQWHUmzMR5J21zmjaW2ziMVZkFQHYLRW8eqfCqxI3KYmNOw48TbeY3iZDvRTJ I50A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=UDnKv70mEcOhhHuHyK23iNhbXNJ/iC7P3ksp9aZBr4E=; b=CT2R11jChiPYGcsg/tH10jxM3n6K7zrc1J0A1wr49j8Z2miQW6TOEYUPyNFrVWLFFQ Y1C3uis3HVKUPoOuTvcioBTjWZTbkQZMUU9Fqc4zqQAAOI2xP+v7Ok2i+MDwN6w7kVq+ 1zSBWwCj5AkzpoSKOwSxwvImA+G+0JTgwKjumg0fmeaAzPKDVrfc9GXGQxXX7UyB5iDQ 6R6a5OPSF+OKNBRZHMZgb8YFPDRtRWWewFqzlrfD93BZUbVjTDcqjk0/kmHfPDD7nCRS shczi0PdetyNwg5lM73ZgCv0QrNDrs1f7zsT8+oKG2/0AYmMeW42GUUFeP3qK84s+FEV V11Q== X-Gm-Message-State: AOAM53073i2f7115M/XwovU+eJRO7E8f+VlnX1riDR9rEE9oBRMMFmEL S0z3t0vu1+kRMvLEdZ1IGpEVLw== X-Google-Smtp-Source: ABdhPJzkWQGWKjZHRJ6PbI+RrI8x1irkzJRnrv6hAgg7+2+hKBnobzWru8fKHdzllPq+PfFTh3unJg== X-Received: by 2002:a63:389:: with SMTP id 131mr14415892pgd.128.1605820017845; Thu, 19 Nov 2020 13:06:57 -0800 (PST) Received: from [192.168.1.11] ([71.212.141.89]) by smtp.gmail.com with ESMTPSA id 23sm802330pfx.210.2020.11.19.13.06.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Nov 2020 13:06:57 -0800 (PST) Subject: Re: [RFC 10/15] target/riscv: rvb: rotate (left/right) To: frank.chang@sifive.com, qemu-devel@nongnu.org, qemu-riscv@nongnu.org References: <20201118083044.13992-1-frank.chang@sifive.com> <20201118083044.13992-11-frank.chang@sifive.com> From: Richard Henderson Message-ID: <52287c37-f10c-a64e-1265-1abfcc39d77e@linaro.org> Date: Thu, 19 Nov 2020 13:06:54 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201118083044.13992-11-frank.chang@sifive.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::42e; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x42e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bastian Koppelmann , Kito Cheng , Alistair Francis , Palmer Dabbelt , Sagar Karandikar Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 11/18/20 12:29 AM, frank.chang@sifive.com wrote: > +static bool trans_rori(DisasContext *ctx, arg_rori *a) > +{ > + REQUIRE_EXT(ctx, RVB); > + > + if (a->shamt >= TARGET_LONG_BITS) { > + return false; > + } > + > + return gen_arith_shamt_tl(ctx, a, &tcg_gen_rotr_tl); > +} We most definitely want to use tcg_gen_rotri_tl here, as we have special expansions of constant shifts for hosts without rotate (e.g. riscv64g ;-). Otherwise, this patch should be included in the shift cleanup discussed upthread. r~