From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42864) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VHZG1-0008MA-08 for qemu-devel@nongnu.org; Thu, 05 Sep 2013 09:06:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VHZFv-0004C9-Ob for qemu-devel@nongnu.org; Thu, 05 Sep 2013 09:05:56 -0400 Received: from cantor2.suse.de ([195.135.220.15]:42182 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VHZFv-0004Bv-Fc for qemu-devel@nongnu.org; Thu, 05 Sep 2013 09:05:51 -0400 Message-ID: <522881AC.6030404@suse.de> Date: Thu, 05 Sep 2013 15:05:48 +0200 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1375366359-11553-1-git-send-email-jjherne@us.ibm.com> <0C872A4D-5B78-4F76-A254-41FDC3147896@suse.de> In-Reply-To: <0C872A4D-5B78-4F76-A254-41FDC3147896@suse.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 0/8] [PATCH RFC v3] s390 cpu hotplug List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: ehabkost@redhat.com, qemu-devel@nongnu.org, "Jason J. Herne" , borntraeger@de.ibm.com, jfrei@linux.vnet.ibm.com, imammedo@redhat.com Am 05.09.2013 14:54, schrieb Alexander Graf: >=20 > On 01.08.2013, at 16:12, Jason J. Herne wrote: >=20 >> From: "Jason J. Herne" >> >> Latest code for cpu Hotplug on S390 architecture. This one is vastly= simpler >> than v2 as we have decided to avoid the command line specification=20 >> of -device s390-cpu. >> >> The last version can be found here: >> http://lists.gnu.org/archive/html/qemu-devel/2013-06/msg01183.html >> >> There is also a patch in this series to add cpu-add to the Qemu monito= r >> interface. >> >> Hotplugged cpus are created in the configured state and can be used by= the >> guest after the guest onlines the cpu by:=20 >> "echo 1 > /sys/bus/cpu/devices/cpuN/online" >> >> Hot unplugging is currently not implemented by this code.=20 >=20 > Very simple and clean patch set. I don't think it deserves the RFC tag. Negative, see my review. If you want to fix up and queue patches 1-2 that's fine with me, but the others need a respin. No major blocker though, just some more footwork mostly related to QOM and Jason's shifted focus on cpu-add rather than device_add. Open issues: * Might ipi_states need to become a device due to migration? * QOM properties considerations * Device creation in qdev initfn * Parent field access * QOM-unfriendly creation and reliance upon helper function Andreas >=20 > Apart from the minor comments I had consider it >=20 > Reviewed-by: Alexander Graf >=20 >=20 > Alex >=20 --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg