From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53758) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VHbTq-0006cS-4d for qemu-devel@nongnu.org; Thu, 05 Sep 2013 11:28:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VHbTk-0008OA-5E for qemu-devel@nongnu.org; Thu, 05 Sep 2013 11:28:22 -0400 Received: from mail-qc0-x234.google.com ([2607:f8b0:400d:c01::234]:37710) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VHbTk-0008NV-1S for qemu-devel@nongnu.org; Thu, 05 Sep 2013 11:28:16 -0400 Received: by mail-qc0-f180.google.com with SMTP id p19so892183qcv.39 for ; Thu, 05 Sep 2013 08:28:15 -0700 (PDT) Sender: Richard Henderson Message-ID: <5228A30C.9050907@twiddle.net> Date: Thu, 05 Sep 2013 08:28:12 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1378391908-22137-1-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1378391908-22137-1-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 0/2] target-arm: Avoid clang sanitizer warnings List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-devel@nongnu.org, patches@linaro.org On 09/05/2013 07:38 AM, Peter Maydell wrote: > These patches avoid some clang sanitizer warnings triggered > on target-arm code which inadvertently shifts into the sign > bit of a signed integer (which is undefined behaviour in C). > > Changes v1->v2: > * made all the CPSR_* defines unsigned for consistency > (suggested by rth in review) > > Peter Maydell (2): > target-arm: Use sextract32() in branch decode > target-arm: Avoid "1 << 31" undefined behaviour > > target-arm/cpu.h | 32 ++++++++++++++++---------------- > target-arm/helper.c | 4 ++-- > target-arm/translate.c | 5 +++-- > 3 files changed, 21 insertions(+), 20 deletions(-) > Reviewed-by: Richard Henderson r~