From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50243) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VHiBL-0003RE-1y for qemu-devel@nongnu.org; Thu, 05 Sep 2013 18:37:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VHiBG-0005Zy-4v for qemu-devel@nongnu.org; Thu, 05 Sep 2013 18:37:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60834) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VHiBF-0005Xz-TC for qemu-devel@nongnu.org; Thu, 05 Sep 2013 18:37:38 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r85Mbauo025410 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 5 Sep 2013 18:37:36 -0400 Message-ID: <522907AF.9040808@redhat.com> Date: Thu, 05 Sep 2013 16:37:35 -0600 From: Eric Blake MIME-Version: 1.0 References: <20130905222853.4097.42724.stgit@bling.home> In-Reply-To: <20130905222853.4097.42724.stgit@bling.home> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4kPdoHDnaOUnOqWUEmaJcGJ7VCNtdLqTw" Subject: Re: [Qemu-devel] [PATCH] vfio-pci: Cleanup error_reports List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Williamson Cc: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --4kPdoHDnaOUnOqWUEmaJcGJ7VCNtdLqTw Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/05/2013 04:29 PM, Alex Williamson wrote: > Remove carriage returns and tweak formatting for error_reports. >=20 > Signed-off-by: Alex Williamson > --- > hw/misc/vfio.c | 24 ++++++++++++------------ > 1 file changed, 12 insertions(+), 12 deletions(-) >=20 > diff --git a/hw/misc/vfio.c b/hw/misc/vfio.c > index 730dec5..a73e7f5 100644 > --- a/hw/misc/vfio.c > +++ b/hw/misc/vfio.c > @@ -3055,13 +3055,15 @@ static int vfio_get_device(VFIOGroup *group, co= nst char *name, VFIODevice *vdev) > ret =3D ioctl(vdev->fd, VFIO_DEVICE_GET_IRQ_INFO, &irq_info); > if (ret) { > /* This can fail for an old kernel or legacy PCI dev */ > - DPRINTF("VFIO_DEVICE_GET_IRQ_INFO failure ret=3D%d\n", ret); > + DPRINTF("VFIO_DEVICE_GET_IRQ_INFO failure: %m\n"); %m is a glibc extension, and does not exist on all platforms. You should probably not make this change. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --4kPdoHDnaOUnOqWUEmaJcGJ7VCNtdLqTw Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSKQevAAoJEKeha0olJ0NqmOsIAKkFAueszaeTMKFH6pNSdEil l9YVxmVAqmHW1KjXmu8mfsOm5dvZdKTWAW6no7DLJgt1n50ixxsdDqQYGGSNSrXK dVxUCiUVrY00Bz8TdPxzYVb18qeUuaayvlUlZhgjGAkQh/MkEKgnsfJ4pHPePRwM ViwOQMN1TljRLvrB8lZcN+oeBt5xkiFFweHBXaibLCe2XBn8tXweNm4HtT0nTrfo oYbpUo1h0SJbZD0CkzhskGxXxD+coesqa3wJiDoTf4nF/vFb+Vgss2et9gLz7m5b TUxTnsDFFieCDSfRQtR4MhFCTEMKNrItmyiecv+YdKlR24EkHt2A8eKHxw+fIVk= =mvJj -----END PGP SIGNATURE----- --4kPdoHDnaOUnOqWUEmaJcGJ7VCNtdLqTw--