From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35726) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VIxOG-0005T4-NR for qemu-devel@nongnu.org; Mon, 09 Sep 2013 05:04:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VIxO9-0004PK-I8 for qemu-devel@nongnu.org; Mon, 09 Sep 2013 05:04:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:28310) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VIxO9-0004PC-Ab for qemu-devel@nongnu.org; Mon, 09 Sep 2013 05:04:05 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r89944ai029771 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 9 Sep 2013 05:04:04 -0400 Message-ID: <522D8F02.6030002@redhat.com> Date: Mon, 09 Sep 2013 11:04:02 +0200 From: Hans de Goede MIME-Version: 1.0 References: <1378714842-31912-1-git-send-email-kraxel@redhat.com> In-Reply-To: <1378714842-31912-1-git-send-email-kraxel@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] ehci: save device pointer in EHCIState List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org Hi, On 09/09/2013 10:20 AM, Gerd Hoffmann wrote: > We'll need a pointer to the actual pci/sysbus device, > stick a pointer to it into the EHCIState struct. > > https://bugzilla.redhat.com/show_bug.cgi?id=1005495 Looks like we've been working on exactly the same bug at the same time, but we've come up with slightly different solutions. If we're going to go this way (which seems the best), you should also modify the qemu_sglist_init call in ehci_init_transfer for consistency, and drop the bus and qbus variable declarations at the top of the functions as those will be unused then. Regards, Hans