* [Qemu-devel] [PATCH] seccomp: adding times() to the whitelist
@ 2013-09-04 12:25 Eduardo Otubo
2013-09-04 13:10 ` Corey Bryant
2013-09-04 14:11 ` Paul Moore
0 siblings, 2 replies; 15+ messages in thread
From: Eduardo Otubo @ 2013-09-04 12:25 UTC (permalink / raw)
To: qemu-devel; +Cc: pmoore, coreyb, Eduardo Otubo
This was causing Qemu process to hang when using -sandbox on.
Related RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1004175
Signed-off-by: Eduardo Otubo <otubo@linux.vnet.ibm.com>
---
qemu-seccomp.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/qemu-seccomp.c b/qemu-seccomp.c
index 37d38f8..69cee44 100644
--- a/qemu-seccomp.c
+++ b/qemu-seccomp.c
@@ -90,6 +90,7 @@ static const struct QemuSeccompSyscall seccomp_whitelist[] = {
{ SCMP_SYS(getuid), 245 },
{ SCMP_SYS(geteuid), 245 },
{ SCMP_SYS(timer_create), 245 },
+ { SCMP_SYS(times), 245 },
{ SCMP_SYS(exit), 245 },
{ SCMP_SYS(clock_gettime), 245 },
{ SCMP_SYS(time), 245 },
--
1.7.1
^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [Qemu-devel] [PATCH] seccomp: adding times() to the whitelist
2013-09-04 12:25 [Qemu-devel] [PATCH] seccomp: adding times() to the whitelist Eduardo Otubo
@ 2013-09-04 13:10 ` Corey Bryant
2013-09-04 14:11 ` Paul Moore
1 sibling, 0 replies; 15+ messages in thread
From: Corey Bryant @ 2013-09-04 13:10 UTC (permalink / raw)
To: Eduardo Otubo; +Cc: pmoore, qemu-devel
On 09/04/2013 08:25 AM, Eduardo Otubo wrote:
> This was causing Qemu process to hang when using -sandbox on.
>
> Related RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1004175
>
> Signed-off-by: Eduardo Otubo <otubo@linux.vnet.ibm.com>
> ---
> qemu-seccomp.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/qemu-seccomp.c b/qemu-seccomp.c
> index 37d38f8..69cee44 100644
> --- a/qemu-seccomp.c
> +++ b/qemu-seccomp.c
> @@ -90,6 +90,7 @@ static const struct QemuSeccompSyscall seccomp_whitelist[] = {
> { SCMP_SYS(getuid), 245 },
> { SCMP_SYS(geteuid), 245 },
> { SCMP_SYS(timer_create), 245 },
> + { SCMP_SYS(times), 245 },
> { SCMP_SYS(exit), 245 },
> { SCMP_SYS(clock_gettime), 245 },
> { SCMP_SYS(time), 245 },
>
Reviewed-by: Corey Bryant <coreyb@linux.vnet.ibm.com>
--
Regards,
Corey Bryant
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Qemu-devel] [PATCH] seccomp: adding times() to the whitelist
2013-09-04 12:25 [Qemu-devel] [PATCH] seccomp: adding times() to the whitelist Eduardo Otubo
2013-09-04 13:10 ` Corey Bryant
@ 2013-09-04 14:11 ` Paul Moore
2013-09-06 18:41 ` Eduardo Otubo
` (2 more replies)
1 sibling, 3 replies; 15+ messages in thread
From: Paul Moore @ 2013-09-04 14:11 UTC (permalink / raw)
To: Eduardo Otubo; +Cc: coreyb, qemu-devel
On Wednesday, September 04, 2013 09:25:08 AM Eduardo Otubo wrote:
> This was causing Qemu process to hang when using -sandbox on.
>
> Related RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1004175
>
> Signed-off-by: Eduardo Otubo <otubo@linux.vnet.ibm.com>
Works for me.
Tested-by: Paul Moore <pmoore@redhat.com>
> ---
> qemu-seccomp.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/qemu-seccomp.c b/qemu-seccomp.c
> index 37d38f8..69cee44 100644
> --- a/qemu-seccomp.c
> +++ b/qemu-seccomp.c
> @@ -90,6 +90,7 @@ static const struct QemuSeccompSyscall seccomp_whitelist[]
> = { { SCMP_SYS(getuid), 245 },
> { SCMP_SYS(geteuid), 245 },
> { SCMP_SYS(timer_create), 245 },
> + { SCMP_SYS(times), 245 },
> { SCMP_SYS(exit), 245 },
> { SCMP_SYS(clock_gettime), 245 },
> { SCMP_SYS(time), 245 },
--
paul moore
security and virtualization @ redhat
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Qemu-devel] [PATCH] seccomp: adding times() to the whitelist
2013-09-04 14:11 ` Paul Moore
@ 2013-09-06 18:41 ` Eduardo Otubo
2013-09-09 10:38 ` Paolo Bonzini
2013-09-13 14:45 ` [Qemu-devel] [PATCH] seccomp: adding times() to the whitelist Paul Moore
2013-09-23 19:53 ` Paul Moore
2 siblings, 1 reply; 15+ messages in thread
From: Eduardo Otubo @ 2013-09-06 18:41 UTC (permalink / raw)
To: Paul Moore; +Cc: Paolo Bonzini, coreyb, qemu-devel
Hello,
Any chance to get this patch applied?
Thanks!
On 09/04/2013 11:11 AM, Paul Moore wrote:
> On Wednesday, September 04, 2013 09:25:08 AM Eduardo Otubo wrote:
>> This was causing Qemu process to hang when using -sandbox on.
>>
>> Related RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1004175
>>
>> Signed-off-by: Eduardo Otubo <otubo@linux.vnet.ibm.com>
>
> Works for me.
>
> Tested-by: Paul Moore <pmoore@redhat.com>
>
>> ---
>> qemu-seccomp.c | 1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/qemu-seccomp.c b/qemu-seccomp.c
>> index 37d38f8..69cee44 100644
>> --- a/qemu-seccomp.c
>> +++ b/qemu-seccomp.c
>> @@ -90,6 +90,7 @@ static const struct QemuSeccompSyscall seccomp_whitelist[]
>> = { { SCMP_SYS(getuid), 245 },
>> { SCMP_SYS(geteuid), 245 },
>> { SCMP_SYS(timer_create), 245 },
>> + { SCMP_SYS(times), 245 },
>> { SCMP_SYS(exit), 245 },
>> { SCMP_SYS(clock_gettime), 245 },
>> { SCMP_SYS(time), 245 },
>
--
Eduardo Otubo
IBM Linux Technology Center
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Qemu-devel] [PATCH] seccomp: adding times() to the whitelist
2013-09-06 18:41 ` Eduardo Otubo
@ 2013-09-09 10:38 ` Paolo Bonzini
2013-09-09 12:36 ` Paul Moore
0 siblings, 1 reply; 15+ messages in thread
From: Paolo Bonzini @ 2013-09-09 10:38 UTC (permalink / raw)
To: Eduardo Otubo; +Cc: Paul Moore, coreyb, qemu-devel
Il 06/09/2013 20:41, Eduardo Otubo ha scritto:
> Hello,
>
> Any chance to get this patch applied?
>
> Thanks!
Paul, perhaps you can add yourself to MAINTAINERS and send a pull request?
Paolo
> On 09/04/2013 11:11 AM, Paul Moore wrote:
>> On Wednesday, September 04, 2013 09:25:08 AM Eduardo Otubo wrote:
>>> This was causing Qemu process to hang when using -sandbox on.
>>>
>>> Related RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1004175
>>>
>>> Signed-off-by: Eduardo Otubo <otubo@linux.vnet.ibm.com>
>>
>> Works for me.
>>
>> Tested-by: Paul Moore <pmoore@redhat.com>
>>
>>> ---
>>> qemu-seccomp.c | 1 +
>>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/qemu-seccomp.c b/qemu-seccomp.c
>>> index 37d38f8..69cee44 100644
>>> --- a/qemu-seccomp.c
>>> +++ b/qemu-seccomp.c
>>> @@ -90,6 +90,7 @@ static const struct QemuSeccompSyscall
>>> seccomp_whitelist[]
>>> = { { SCMP_SYS(getuid), 245 },
>>> { SCMP_SYS(geteuid), 245 },
>>> { SCMP_SYS(timer_create), 245 },
>>> + { SCMP_SYS(times), 245 },
>>> { SCMP_SYS(exit), 245 },
>>> { SCMP_SYS(clock_gettime), 245 },
>>> { SCMP_SYS(time), 245 },
>>
>
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Qemu-devel] [PATCH] seccomp: adding times() to the whitelist
2013-09-09 10:38 ` Paolo Bonzini
@ 2013-09-09 12:36 ` Paul Moore
2013-09-09 13:20 ` Eduardo Otubo
0 siblings, 1 reply; 15+ messages in thread
From: Paul Moore @ 2013-09-09 12:36 UTC (permalink / raw)
To: Paolo Bonzini, Eduardo Otubo; +Cc: coreyb, qemu-devel
On Monday, September 09, 2013 12:38:12 PM Paolo Bonzini wrote:
> Il 06/09/2013 20:41, Eduardo Otubo ha scritto:
> > Hello,
> >
> > Any chance to get this patch applied?
> >
> > Thanks!
>
> Paul, perhaps you can add yourself to MAINTAINERS and send a pull request?
>
> Paolo
Out of respect for the work that Eduardo has done, and is continuing to do,
with the QEMU seccomp filtering, I think Eduardo should be the one to take on
this role. If Eduardo declines I'll do ahead and submit a patch adding myself
to the MAINTAINERS file.
> > On 09/04/2013 11:11 AM, Paul Moore wrote:
> >> On Wednesday, September 04, 2013 09:25:08 AM Eduardo Otubo wrote:
> >>> This was causing Qemu process to hang when using -sandbox on.
> >>>
> >>> Related RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1004175
> >>>
> >>> Signed-off-by: Eduardo Otubo <otubo@linux.vnet.ibm.com>
> >>
> >> Works for me.
> >>
> >> Tested-by: Paul Moore <pmoore@redhat.com>
> >>
> >>> ---
> >>>
> >>> qemu-seccomp.c | 1 +
> >>> 1 files changed, 1 insertions(+), 0 deletions(-)
> >>>
> >>> diff --git a/qemu-seccomp.c b/qemu-seccomp.c
> >>> index 37d38f8..69cee44 100644
> >>> --- a/qemu-seccomp.c
> >>> +++ b/qemu-seccomp.c
> >>> @@ -90,6 +90,7 @@ static const struct QemuSeccompSyscall
> >>> seccomp_whitelist[]
> >>> = { { SCMP_SYS(getuid), 245 },
> >>>
> >>> { SCMP_SYS(geteuid), 245 },
> >>> { SCMP_SYS(timer_create), 245 },
> >>>
> >>> + { SCMP_SYS(times), 245 },
> >>>
> >>> { SCMP_SYS(exit), 245 },
> >>> { SCMP_SYS(clock_gettime), 245 },
> >>> { SCMP_SYS(time), 245 },
--
paul moore
security and virtualization @ redhat
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Qemu-devel] [PATCH] seccomp: adding times() to the whitelist
2013-09-09 12:36 ` Paul Moore
@ 2013-09-09 13:20 ` Eduardo Otubo
2013-09-09 13:48 ` [Qemu-devel] seccomp submaintainer? (was Re: [PATCH] seccomp: adding times() to the whitelist) Paolo Bonzini
0 siblings, 1 reply; 15+ messages in thread
From: Eduardo Otubo @ 2013-09-09 13:20 UTC (permalink / raw)
To: Paul Moore; +Cc: Paolo Bonzini, coreyb, qemu-devel
On 09/09/2013 09:36 AM, Paul Moore wrote:
> On Monday, September 09, 2013 12:38:12 PM Paolo Bonzini wrote:
>> Il 06/09/2013 20:41, Eduardo Otubo ha scritto:
>>> Hello,
>>>
>>> Any chance to get this patch applied?
>>>
>>> Thanks!
>>
>> Paul, perhaps you can add yourself to MAINTAINERS and send a pull request?
>>
>> Paolo
>
> Out of respect for the work that Eduardo has done, and is continuing to do,
> with the QEMU seccomp filtering, I think Eduardo should be the one to take on
> this role. If Eduardo declines I'll do ahead and submit a patch adding myself
> to the MAINTAINERS file.
If this is ok for everyone, I would be really glad to take this role to
myself. Paul, thanks for this vote of confidence. Paolo, should I send a
patch for MAINTAINERS right away?
Regards,
>
>>> On 09/04/2013 11:11 AM, Paul Moore wrote:
>>>> On Wednesday, September 04, 2013 09:25:08 AM Eduardo Otubo wrote:
>>>>> This was causing Qemu process to hang when using -sandbox on.
>>>>>
>>>>> Related RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1004175
>>>>>
>>>>> Signed-off-by: Eduardo Otubo <otubo@linux.vnet.ibm.com>
>>>>
>>>> Works for me.
>>>>
>>>> Tested-by: Paul Moore <pmoore@redhat.com>
>>>>
>>>>> ---
>>>>>
>>>>> qemu-seccomp.c | 1 +
>>>>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>>>>
>>>>> diff --git a/qemu-seccomp.c b/qemu-seccomp.c
>>>>> index 37d38f8..69cee44 100644
>>>>> --- a/qemu-seccomp.c
>>>>> +++ b/qemu-seccomp.c
>>>>> @@ -90,6 +90,7 @@ static const struct QemuSeccompSyscall
>>>>> seccomp_whitelist[]
>>>>> = { { SCMP_SYS(getuid), 245 },
>>>>>
>>>>> { SCMP_SYS(geteuid), 245 },
>>>>> { SCMP_SYS(timer_create), 245 },
>>>>>
>>>>> + { SCMP_SYS(times), 245 },
>>>>>
>>>>> { SCMP_SYS(exit), 245 },
>>>>> { SCMP_SYS(clock_gettime), 245 },
>>>>> { SCMP_SYS(time), 245 },
>
--
Eduardo Otubo
IBM Linux Technology Center
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Qemu-devel] seccomp submaintainer? (was Re: [PATCH] seccomp: adding times() to the whitelist)
2013-09-09 13:20 ` Eduardo Otubo
@ 2013-09-09 13:48 ` Paolo Bonzini
2013-09-09 14:44 ` Paul Moore
2013-09-09 16:40 ` Anthony Liguori
0 siblings, 2 replies; 15+ messages in thread
From: Paolo Bonzini @ 2013-09-09 13:48 UTC (permalink / raw)
To: Eduardo Otubo; +Cc: Paul Moore, coreyb, qemu-devel, Anthony Liguori
Il 09/09/2013 15:20, Eduardo Otubo ha scritto:
>> Out of respect for the work that Eduardo has done, and is
>> continuing to do, with the QEMU seccomp filtering, I think Eduardo
>> should be the one to take on this role. If Eduardo declines I'll do
>> ahead and submit a patch adding myself to the MAINTAINERS file.
>
> If this is ok for everyone, I would be really glad to take this role to
> myself. Paul, thanks for this vote of confidence. Paolo, should I send a
> patch for MAINTAINERS right away?
Ok, I was suggesting Paul because he was the one doing reviews.
Eduardo, that is also okay for me. However, even as a maintainer please
do wait for Paul's reviews. Many areas of QEMU have maintainers that do
not send their own patches without a review, so this wouldn't be a new
rule. :)
Please wait for Anthony's ack. I changed the subject and CCed him to
grab his attention.
Paolo
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Qemu-devel] seccomp submaintainer? (was Re: [PATCH] seccomp: adding times() to the whitelist)
2013-09-09 13:48 ` [Qemu-devel] seccomp submaintainer? (was Re: [PATCH] seccomp: adding times() to the whitelist) Paolo Bonzini
@ 2013-09-09 14:44 ` Paul Moore
2013-09-09 16:40 ` Anthony Liguori
1 sibling, 0 replies; 15+ messages in thread
From: Paul Moore @ 2013-09-09 14:44 UTC (permalink / raw)
To: Paolo Bonzini, Eduardo Otubo, Anthony Liguori; +Cc: coreyb, qemu-devel
On Monday, September 09, 2013 03:48:09 PM Paolo Bonzini wrote:
> Il 09/09/2013 15:20, Eduardo Otubo ha scritto:
> >> Out of respect for the work that Eduardo has done, and is
> >> continuing to do, with the QEMU seccomp filtering, I think Eduardo
> >> should be the one to take on this role. If Eduardo declines I'll do
> >> ahead and submit a patch adding myself to the MAINTAINERS file.
> >
> > If this is ok for everyone, I would be really glad to take this role to
> > myself. Paul, thanks for this vote of confidence. Paolo, should I send a
> > patch for MAINTAINERS right away?
>
> Ok, I was suggesting Paul because he was the one doing reviews.
>
> Eduardo, that is also okay for me. However, even as a maintainer please
> do wait for Paul's reviews. Many areas of QEMU have maintainers that do
> not send their own patches without a review, so this wouldn't be a new
> rule. :)
Okay, with respect to maintainership, I was thinking more along the lines of
the Linux Kernel where those that do the work get the job; it looks like QEMU
has a slightly different twist on the idea. If it makes more sense to the
QEMU devs you can always add me as a co-maintainer.
Regardless, I do plan on continuing to review/test patches and I don't expect
that to change in the near future.
> Please wait for Anthony's ack. I changed the subject and CCed him to
> grab his attention.
>
> Paolo
--
paul moore
security and virtualization @ redhat
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Qemu-devel] seccomp submaintainer? (was Re: [PATCH] seccomp: adding times() to the whitelist)
2013-09-09 13:48 ` [Qemu-devel] seccomp submaintainer? (was Re: [PATCH] seccomp: adding times() to the whitelist) Paolo Bonzini
2013-09-09 14:44 ` Paul Moore
@ 2013-09-09 16:40 ` Anthony Liguori
1 sibling, 0 replies; 15+ messages in thread
From: Anthony Liguori @ 2013-09-09 16:40 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: Paul Moore, coreyb, qemu-devel, Eduardo Otubo
On Mon, Sep 9, 2013 at 8:48 AM, Paolo Bonzini <pbonzini@redhat.com> wrote:
> Il 09/09/2013 15:20, Eduardo Otubo ha scritto:
>>> Out of respect for the work that Eduardo has done, and is
>>> continuing to do, with the QEMU seccomp filtering, I think Eduardo
>>> should be the one to take on this role. If Eduardo declines I'll do
>>> ahead and submit a patch adding myself to the MAINTAINERS file.
>>
>> If this is ok for everyone, I would be really glad to take this role to
>> myself. Paul, thanks for this vote of confidence. Paolo, should I send a
>> patch for MAINTAINERS right away?
>
> Ok, I was suggesting Paul because he was the one doing reviews.
>
> Eduardo, that is also okay for me. However, even as a maintainer please
> do wait for Paul's reviews. Many areas of QEMU have maintainers that do
> not send their own patches without a review, so this wouldn't be a new
> rule. :)
>
> Please wait for Anthony's ack. I changed the subject and CCed him to
> grab his attention.
Ack. I think it's a great idea.
Regards,
Anthony Liguori
>
> Paolo
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Qemu-devel] [PATCH] seccomp: adding times() to the whitelist
2013-09-04 14:11 ` Paul Moore
2013-09-06 18:41 ` Eduardo Otubo
@ 2013-09-13 14:45 ` Paul Moore
2013-09-23 19:49 ` Eduardo Otubo
2013-09-23 19:53 ` Paul Moore
2 siblings, 1 reply; 15+ messages in thread
From: Paul Moore @ 2013-09-13 14:45 UTC (permalink / raw)
To: Eduardo Otubo, qemu-devel; +Cc: coreyb
On Wednesday, September 04, 2013 10:11:10 AM Paul Moore wrote:
> On Wednesday, September 04, 2013 09:25:08 AM Eduardo Otubo wrote:
> > This was causing Qemu process to hang when using -sandbox on.
> >
> > Related RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1004175
> >
> > Signed-off-by: Eduardo Otubo <otubo@linux.vnet.ibm.com>
>
> Works for me.
>
> Tested-by: Paul Moore <pmoore@redhat.com>
I fear this patch may have been lost in the maintainer discussion - can we
merge this fix please?
> > ---
> >
> > qemu-seccomp.c | 1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/qemu-seccomp.c b/qemu-seccomp.c
> > index 37d38f8..69cee44 100644
> > --- a/qemu-seccomp.c
> > +++ b/qemu-seccomp.c
> > @@ -90,6 +90,7 @@ static const struct QemuSeccompSyscall
> > seccomp_whitelist[] = { { SCMP_SYS(getuid), 245 },
> >
> > { SCMP_SYS(geteuid), 245 },
> > { SCMP_SYS(timer_create), 245 },
> >
> > + { SCMP_SYS(times), 245 },
> >
> > { SCMP_SYS(exit), 245 },
> > { SCMP_SYS(clock_gettime), 245 },
> > { SCMP_SYS(time), 245 },
--
paul moore
security and virtualization @ redhat
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Qemu-devel] [PATCH] seccomp: adding times() to the whitelist
2013-09-13 14:45 ` [Qemu-devel] [PATCH] seccomp: adding times() to the whitelist Paul Moore
@ 2013-09-23 19:49 ` Eduardo Otubo
2013-09-23 19:54 ` Anthony Liguori
0 siblings, 1 reply; 15+ messages in thread
From: Eduardo Otubo @ 2013-09-23 19:49 UTC (permalink / raw)
To: Paul Moore; +Cc: coreyb, qemu-devel
On 09/13/2013 11:45 AM, Paul Moore wrote:
> On Wednesday, September 04, 2013 10:11:10 AM Paul Moore wrote:
>> On Wednesday, September 04, 2013 09:25:08 AM Eduardo Otubo wrote:
>>> This was causing Qemu process to hang when using -sandbox on.
>>>
>>> Related RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1004175
>>>
>>> Signed-off-by: Eduardo Otubo <otubo@linux.vnet.ibm.com>
>>
>> Works for me.
>>
>> Tested-by: Paul Moore <pmoore@redhat.com>
>
> I fear this patch may have been lost in the maintainer discussion - can we
> merge this fix please?
Just another poke on this patch. Poor little bug
https://bugzilla.redhat.com/show_bug.cgi?id=1004175 is waiting for a fix.
Thanks.
>
>>> ---
>>>
>>> qemu-seccomp.c | 1 +
>>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/qemu-seccomp.c b/qemu-seccomp.c
>>> index 37d38f8..69cee44 100644
>>> --- a/qemu-seccomp.c
>>> +++ b/qemu-seccomp.c
>>> @@ -90,6 +90,7 @@ static const struct QemuSeccompSyscall
>>> seccomp_whitelist[] = { { SCMP_SYS(getuid), 245 },
>>>
>>> { SCMP_SYS(geteuid), 245 },
>>> { SCMP_SYS(timer_create), 245 },
>>>
>>> + { SCMP_SYS(times), 245 },
>>>
>>> { SCMP_SYS(exit), 245 },
>>> { SCMP_SYS(clock_gettime), 245 },
>>> { SCMP_SYS(time), 245 },
>
--
Eduardo Otubo
IBM Linux Technology Center
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Qemu-devel] [PATCH] seccomp: adding times() to the whitelist
2013-09-04 14:11 ` Paul Moore
2013-09-06 18:41 ` Eduardo Otubo
2013-09-13 14:45 ` [Qemu-devel] [PATCH] seccomp: adding times() to the whitelist Paul Moore
@ 2013-09-23 19:53 ` Paul Moore
2013-09-23 19:56 ` Eduardo Otubo
2 siblings, 1 reply; 15+ messages in thread
From: Paul Moore @ 2013-09-23 19:53 UTC (permalink / raw)
To: Eduardo Otubo; +Cc: coreyb, qemu-devel
On Wednesday, September 04, 2013 10:11:10 AM Paul Moore wrote:
> On Wednesday, September 04, 2013 09:25:08 AM Eduardo Otubo wrote:
> > This was causing Qemu process to hang when using -sandbox on.
> >
> > Related RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1004175
> >
> > Signed-off-by: Eduardo Otubo <otubo@linux.vnet.ibm.com>
>
> Works for me.
>
> Tested-by: Paul Moore <pmoore@redhat.com>
Eduardo, perhaps you should just merge this into your tree and send a pull
request? This fix should also go into -stable.
Acked-by: Paul Moore <pmoore@redhat.com>
> > ---
> >
> > qemu-seccomp.c | 1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/qemu-seccomp.c b/qemu-seccomp.c
> > index 37d38f8..69cee44 100644
> > --- a/qemu-seccomp.c
> > +++ b/qemu-seccomp.c
> > @@ -90,6 +90,7 @@ static const struct QemuSeccompSyscall
> > seccomp_whitelist[] = { { SCMP_SYS(getuid), 245 },
> >
> > { SCMP_SYS(geteuid), 245 },
> > { SCMP_SYS(timer_create), 245 },
> >
> > + { SCMP_SYS(times), 245 },
> >
> > { SCMP_SYS(exit), 245 },
> > { SCMP_SYS(clock_gettime), 245 },
> > { SCMP_SYS(time), 245 },
--
paul moore
security and virtualization @ redhat
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Qemu-devel] [PATCH] seccomp: adding times() to the whitelist
2013-09-23 19:49 ` Eduardo Otubo
@ 2013-09-23 19:54 ` Anthony Liguori
0 siblings, 0 replies; 15+ messages in thread
From: Anthony Liguori @ 2013-09-23 19:54 UTC (permalink / raw)
To: Eduardo Otubo; +Cc: Paul Moore, coreyb, qemu-devel
[-- Attachment #1: Type: text/plain, Size: 1792 bytes --]
On Mon, Sep 23, 2013 at 2:49 PM, Eduardo Otubo <otubo@linux.vnet.ibm.com>wrote:
>
>
> On 09/13/2013 11:45 AM, Paul Moore wrote:
>
>> On Wednesday, September 04, 2013 10:11:10 AM Paul Moore wrote:
>>
>>> On Wednesday, September 04, 2013 09:25:08 AM Eduardo Otubo wrote:
>>>
>>>> This was causing Qemu process to hang when using -sandbox on.
>>>>
>>>> Related RHBZ: https://bugzilla.redhat.com/**show_bug.cgi?id=1004175<https://bugzilla.redhat.com/show_bug.cgi?id=1004175>
>>>>
>>>> Signed-off-by: Eduardo Otubo <otubo@linux.vnet.ibm.com>
>>>>
>>>
>>> Works for me.
>>>
>>> Tested-by: Paul Moore <pmoore@redhat.com>
>>>
>>
>> I fear this patch may have been lost in the maintainer discussion - can we
>> merge this fix please?
>>
>
> Just another poke on this patch. Poor little bug
> https://bugzilla.redhat.com/**show_bug.cgi?id=1004175<https://bugzilla.redhat.com/show_bug.cgi?id=1004175>is waiting for a fix.
>
> Thanks.
M: Eduardo Otubo <otubo@linux.vnet.ibm.com>
S: Supported
F: qemu-seccomp.c
F: include/sysemu/seccomp.h
You should be sending a pull request Eduardo.
Regards,
Anthony Liguori
>
>
>
>> ---
>>>>
>>>> qemu-seccomp.c | 1 +
>>>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>>>
>>>> diff --git a/qemu-seccomp.c b/qemu-seccomp.c
>>>> index 37d38f8..69cee44 100644
>>>> --- a/qemu-seccomp.c
>>>> +++ b/qemu-seccomp.c
>>>> @@ -90,6 +90,7 @@ static const struct QemuSeccompSyscall
>>>> seccomp_whitelist[] = { { SCMP_SYS(getuid), 245 },
>>>>
>>>> { SCMP_SYS(geteuid), 245 },
>>>> { SCMP_SYS(timer_create), 245 },
>>>>
>>>> + { SCMP_SYS(times), 245 },
>>>>
>>>> { SCMP_SYS(exit), 245 },
>>>> { SCMP_SYS(clock_gettime), 245 },
>>>> { SCMP_SYS(time), 245 },
>>>>
>>>
>>
> --
> Eduardo Otubo
> IBM Linux Technology Center
>
>
>
[-- Attachment #2: Type: text/html, Size: 3524 bytes --]
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Qemu-devel] [PATCH] seccomp: adding times() to the whitelist
2013-09-23 19:53 ` Paul Moore
@ 2013-09-23 19:56 ` Eduardo Otubo
0 siblings, 0 replies; 15+ messages in thread
From: Eduardo Otubo @ 2013-09-23 19:56 UTC (permalink / raw)
To: Paul Moore; +Cc: coreyb, qemu-devel
On 09/23/2013 04:53 PM, Paul Moore wrote:
> On Wednesday, September 04, 2013 10:11:10 AM Paul Moore wrote:
>> On Wednesday, September 04, 2013 09:25:08 AM Eduardo Otubo wrote:
>>> This was causing Qemu process to hang when using -sandbox on.
>>>
>>> Related RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1004175
>>>
>>> Signed-off-by: Eduardo Otubo <otubo@linux.vnet.ibm.com>
>>
>> Works for me.
>>
>> Tested-by: Paul Moore <pmoore@redhat.com>
>
> Eduardo, perhaps you should just merge this into your tree and send a pull
> request? This fix should also go into -stable.
OH you're absolutely right, I'll just do it! Thanks for the heads up,
forgot I have special powers now.
>
> Acked-by: Paul Moore <pmoore@redhat.com>
>
>>> ---
>>>
>>> qemu-seccomp.c | 1 +
>>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/qemu-seccomp.c b/qemu-seccomp.c
>>> index 37d38f8..69cee44 100644
>>> --- a/qemu-seccomp.c
>>> +++ b/qemu-seccomp.c
>>> @@ -90,6 +90,7 @@ static const struct QemuSeccompSyscall
>>> seccomp_whitelist[] = { { SCMP_SYS(getuid), 245 },
>>>
>>> { SCMP_SYS(geteuid), 245 },
>>> { SCMP_SYS(timer_create), 245 },
>>>
>>> + { SCMP_SYS(times), 245 },
>>>
>>> { SCMP_SYS(exit), 245 },
>>> { SCMP_SYS(clock_gettime), 245 },
>>> { SCMP_SYS(time), 245 },
>
--
Eduardo Otubo
IBM Linux Technology Center
^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2013-09-23 19:57 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-04 12:25 [Qemu-devel] [PATCH] seccomp: adding times() to the whitelist Eduardo Otubo
2013-09-04 13:10 ` Corey Bryant
2013-09-04 14:11 ` Paul Moore
2013-09-06 18:41 ` Eduardo Otubo
2013-09-09 10:38 ` Paolo Bonzini
2013-09-09 12:36 ` Paul Moore
2013-09-09 13:20 ` Eduardo Otubo
2013-09-09 13:48 ` [Qemu-devel] seccomp submaintainer? (was Re: [PATCH] seccomp: adding times() to the whitelist) Paolo Bonzini
2013-09-09 14:44 ` Paul Moore
2013-09-09 16:40 ` Anthony Liguori
2013-09-13 14:45 ` [Qemu-devel] [PATCH] seccomp: adding times() to the whitelist Paul Moore
2013-09-23 19:49 ` Eduardo Otubo
2013-09-23 19:54 ` Anthony Liguori
2013-09-23 19:53 ` Paul Moore
2013-09-23 19:56 ` Eduardo Otubo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).