From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39502) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VJ29Q-0003Vi-SR for qemu-devel@nongnu.org; Mon, 09 Sep 2013 10:09:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VJ29G-0005L2-Uy for qemu-devel@nongnu.org; Mon, 09 Sep 2013 10:09:12 -0400 Received: from mail-vc0-x22d.google.com ([2607:f8b0:400c:c03::22d]:56902) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VJ29G-0005KW-PJ for qemu-devel@nongnu.org; Mon, 09 Sep 2013 10:09:02 -0400 Received: by mail-vc0-f173.google.com with SMTP id id13so3940579vcb.18 for ; Mon, 09 Sep 2013 07:09:01 -0700 (PDT) Sender: Richard Henderson Message-ID: <522DD679.9030201@twiddle.net> Date: Mon, 09 Sep 2013 07:08:57 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1378144503-15808-1-git-send-email-rth@twiddle.net> <522D8339.1090002@huawei.com> In-Reply-To: <522D8339.1090002@huawei.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 00/29] tcg-aarch64 improvements List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Claudio Fontana Cc: qemu-devel@nongnu.org On 09/09/2013 01:13 AM, Claudio Fontana wrote: > after carefully reading and testing your patches, this is how I suggest to proceed: > > first do the implementation of the new functionality (tcg opcodes, jit) in a way that is consistent with the existing code. > No type changes, no refactoring, no beautification. > > Once we agree on those, introduce the meaningful restructuring you want to do, > like the new INSN type, the "don't handle mov/movi in tcg_out_op", the TCG_OPF_64BIT thing, etc. > > Last do the cosmetic stuff if you really want to do it, like the change all ext to bool (note that there is no point if the callers still use "1" and "0": adapt them as well) etc. No, I don't agree. Especially with respect to the insn type. I'd much rather do all the "cosmetic stuff", as you put it, first. It makes all of the "real" changes much easier to understand. r~