From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56304)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Claudio.Fontana@huawei.com>) id 1VJ2zJ-0004ll-Tl
	for qemu-devel@nongnu.org; Mon, 09 Sep 2013 11:02:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Claudio.Fontana@huawei.com>) id 1VJ2zD-00061h-TW
	for qemu-devel@nongnu.org; Mon, 09 Sep 2013 11:02:49 -0400
Received: from lhrrgout.huawei.com ([194.213.3.17]:36080)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Claudio.Fontana@huawei.com>) id 1VJ2zD-00060M-LD
	for qemu-devel@nongnu.org; Mon, 09 Sep 2013 11:02:43 -0400
Message-ID: <522DE2EF.1010902@huawei.com>
Date: Mon, 9 Sep 2013 17:02:07 +0200
From: Claudio Fontana <claudio.fontana@huawei.com>
MIME-Version: 1.0
References: <1378144503-15808-1-git-send-email-rth@twiddle.net>
	<522D8339.1090002@huawei.com> <522DD679.9030201@twiddle.net>
In-Reply-To: <522DD679.9030201@twiddle.net>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 00/29] tcg-aarch64 improvements
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: qemu-devel@nongnu.org

On 09.09.2013 16:08, Richard Henderson wrote:
> On 09/09/2013 01:13 AM, Claudio Fontana wrote:
>> after carefully reading and testing your patches, this is how I suggest to proceed: 
>>
>> first do the implementation of the new functionality (tcg opcodes, jit) in a way that is consistent with the existing code.
>> No type changes, no refactoring, no beautification.
>>
>> Once we agree on those, introduce the meaningful restructuring you want to do,
>> like the new INSN type, the "don't handle mov/movi in tcg_out_op", the TCG_OPF_64BIT thing, etc.
>>
>> Last do the cosmetic stuff if you really want to do it, like the change all ext to bool (note that there is no point if the callers still use "1" and "0": adapt them as well) etc.
> 
> No, I don't agree.  Especially with respect to the insn type.
> 
> I'd much rather do all the "cosmetic stuff", as you put it, first.  It makes
> all of the "real" changes much easier to understand.
> 
> 
> r~
> 

I guess we are stuck then. With the cosmetic and restructuring stuff coming before, I cannot cherry pick the good parts later.