From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60278) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VJ52y-0001py-Qp for qemu-devel@nongnu.org; Mon, 09 Sep 2013 13:14:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VJ52p-0004Sq-JZ for qemu-devel@nongnu.org; Mon, 09 Sep 2013 13:14:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:20900) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VJ52p-0004Se-C0 for qemu-devel@nongnu.org; Mon, 09 Sep 2013 13:14:35 -0400 Message-ID: <522E01F5.1090209@redhat.com> Date: Mon, 09 Sep 2013 19:14:29 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1378189680-11987-1-git-send-email-aurelien@aurel32.net> <52258DE2.80108@redhat.com> <20130909170431.GA23537@ohm.aurel32.net> In-Reply-To: <20130909170431.GA23537@ohm.aurel32.net> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/4] tcg/optimize: fixes and improvements List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aurelien Jarno Cc: qemu-devel@nongnu.org, Richard Henderson Il 09/09/2013 19:04, Aurelien Jarno ha scritto: > I have just checked, and it does indeed work for a few cases involving > constants. That said, it doesn't change the resulting TCG code, as these > cases were already handled by some other optimizations. > > That let me ask a question, about why the bit propagation has been added > in the middle of other optimizations, and not for example immediately > after swapping commutative ops or just before the constant folding. I think it was just an artifact of /me rebasing the patch after other optimizations were introduced. Paolo