From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60568) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VJHWr-0004ev-LK for qemu-devel@nongnu.org; Tue, 10 Sep 2013 02:34:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VJHWm-0001Zb-Ai for qemu-devel@nongnu.org; Tue, 10 Sep 2013 02:34:25 -0400 Received: from mail-ee0-x231.google.com ([2a00:1450:4013:c00::231]:58602) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VJHWl-0001ZX-Vu for qemu-devel@nongnu.org; Tue, 10 Sep 2013 02:34:20 -0400 Received: by mail-ee0-f49.google.com with SMTP id d41so3547924eek.8 for ; Mon, 09 Sep 2013 23:34:19 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <522EBD6E.5080400@redhat.com> Date: Tue, 10 Sep 2013 08:34:22 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1378774978-22602-1-git-send-email-famz@redhat.com> <1378774978-22602-2-git-send-email-famz@redhat.com> In-Reply-To: <1378774978-22602-2-git-send-email-famz@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH v3 1/5] make.rule: fix $(obj) to a real relative path List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: peter.maydell@linaro.org, mjt@tls.msk.ru, qemu-devel@nongnu.org, stefanha@redhat.com, vilanova@ac.upc.edu, rth@twiddle.net Il 10/09/2013 03:02, Fam Zheng ha scritto: > Makefile.target includes rule.mak and unnested common-obj-y, then prefix > them with '../', this will ignore object specific QEMU_CFLAGS in subdir > Makefile.objs: > > $(obj)/curl.o: QEMU_CFLAGS += $(CURL_CFLAGS) > > Because $(obj) here is './block', instead of '../block'. This doesn't > hurt compiling because we basically build all .o from top Makefile, > before entering Makefile.target, but it will affact arriving per-object > libs support. > > The starting point of $(obj) is fixed in $(obj-base) before including > ./Makefile.objs, to get consistency with nested Makefile rules in target > rule and variable definition. > > Signed-off-by: Fam Zheng Glad this worked. ) > -dummy := $(call unnest-vars) > diff --git a/Makefile.target b/Makefile.target > index 9a49852..381022d 100644 > --- a/Makefile.target > +++ b/Makefile.target > @@ -143,13 +143,15 @@ endif # CONFIG_SOFTMMU > # Workaround for http://gcc.gnu.org/PR55489, see configure. > %/translate.o: QEMU_CFLAGS += $(TRANSLATE_OPT_CFLAGS) > > -nested-vars += obj-y > +nested-vars += obj-y block-obj-y common-obj-y > > # This resolves all nested paths, so it must come last This comment is now obsolete. > include $(SRC_PATH)/Makefile.objs > +obj-base := .. Strictly speaking obj-base=.. is incorrect for obj-y, isn't it? Does it work if you do block-obj-y = ../ common-obj-y = ../ instead of including $(SRC_PATH)/Makefile.objs? Then obj-base can be empty and is not needed. But the patch looks good already, I'm asking mostly to get a better understanding of the system. Paolo > +dummy := $(call unnest-vars) > > all-obj-y = $(obj-y) > -all-obj-y += $(addprefix ../, $(common-obj-y)) > +all-obj-y += $(addprefix ../, $(common-obj-y) $(block-obj-y)) > > ifndef CONFIG_HAIKU > LIBS+=-lm > diff --git a/configure b/configure > index e989609..cc3cd4d 100755 > --- a/configure > +++ b/configure > @@ -2251,6 +2251,7 @@ fi > if $pkg_config --atleast-version=$glib_req_ver gthread-2.0; then > glib_cflags=`$pkg_config --cflags gthread-2.0` > glib_libs=`$pkg_config --libs gthread-2.0` > + CFLAGS="$glib_cflags $CFLAGS" > LIBS="$glib_libs $LIBS" > libs_qga="$glib_libs $libs_qga" > else > diff --git a/rules.mak b/rules.mak > index 4499745..3ff7d7a 100644 > --- a/rules.mak > +++ b/rules.mak > @@ -103,7 +103,7 @@ clean: clean-timestamp > > # magic to descend into other directories > > -obj := . > +obj = $(obj-base) > old-nested-dirs := > > define push-var > @@ -119,9 +119,11 @@ endef > > define unnest-dir > $(foreach var,$(nested-vars),$(call push-var,$(var),$1/)) > -$(eval obj := $(obj)/$1) > +$(eval obj-parent-$1 := $(obj)) > +$(eval obj := $(if $(obj),$(obj)/$1,$1)) > $(eval include $(SRC_PATH)/$1/Makefile.objs) > -$(eval obj := $(patsubst %/$1,%,$(obj))) > +$(eval obj := $(obj-parent-$1)) > +$(eval obj-parent-$1 := ) > $(foreach var,$(nested-vars),$(call pop-var,$(var),$1/)) > endef > > diff --git a/tests/Makefile b/tests/Makefile > index baba9e9..15ef039 100644 > --- a/tests/Makefile > +++ b/tests/Makefile > @@ -110,6 +110,10 @@ test-qapi-obj-y = tests/test-qapi-visit.o tests/test-qapi-types.o > $(test-obj-y): QEMU_INCLUDES += -Itests > QEMU_CFLAGS += -I$(SRC_PATH)/tests > > +nested-vars := block-obj-y > +obj-base := .. > +dummy := $(call unnest-vars) > + > tests/test-x86-cpuid.o: QEMU_INCLUDES += -I$(SRC_PATH)/target-i386 > > tests/check-qint$(EXESUF): tests/check-qint.o libqemuutil.a >